From d120a6805e77a683b8c76ca7b3986f6d533dd8ed Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Thu, 11 Oct 2018 18:44:11 +0300
Subject: [PATCH] fix(heMakeRecommendation): message for EIC is visible only
when He makes decision to publish/reject
---
.../src/contextualBoxes/HERecommendation.js | 18 ++++++++----------
.../src/components/ManuscriptPage.js | 4 +---
2 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js b/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
index b6184d7fb..a8f501ee8 100644
--- a/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
+++ b/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
@@ -68,17 +68,15 @@ const HERecommendation = ({
</ItemOverrideAlert>
</Row>
- {get(formValues, 'recommendation') === 'publish' ||
- get(formValues, 'recommendation') === 'reject' ? (
+ {get(formValues, 'recommendation') === 'minor' ||
+ get(formValues, 'recommendation') === 'major' ? (
<Row mt={2}>
- <ItemOverrideAlert vertical>
- <Label required>Message for Author</Label>
- <ValidatedField
- component={Textarea}
- name="public"
- validate={[required]}
- />
- </ItemOverrideAlert>
+ <ResponsiveItem mr={1} vertical>
+ <Label>
+ Message for Author <Text secondary>Optional</Text>
+ </Label>
+ <ValidatedField component={Textarea} name="public" />
+ </ResponsiveItem>
</Row>
) : (
<ResponsiveRow mt={2}>
diff --git a/packages/component-manuscript/src/components/ManuscriptPage.js b/packages/component-manuscript/src/components/ManuscriptPage.js
index aa69fb6d1..ac4868da0 100644
--- a/packages/component-manuscript/src/components/ManuscriptPage.js
+++ b/packages/component-manuscript/src/components/ManuscriptPage.js
@@ -170,9 +170,7 @@ export default compose(
eicDecision: getFormValues('eic-decision')(state),
reviewerReport: getFormValues('reviewerReport')(state),
responseToInvitation: getFormValues('answer-invitation')(state),
- editorialRecommendation: getFormValues('editorialRecommendation')(
- state,
- ),
+ editorialRecommendation: getFormValues('HERecommendation')(state),
},
invitationsWithReviewers: getInvitationsWithReviewersForFragment(
state,
--
GitLab