From d8b3a45561b3fc0fcf7779a3d00a1b2f47ef89db Mon Sep 17 00:00:00 2001 From: Alexandru Munteanu <alexandru.munt@gmail.com> Date: Wed, 16 May 2018 14:16:09 +0300 Subject: [PATCH] fix(review reports): crash when recommendation has no comments --- .../src/components/ReviewReportCard.js | 4 ++-- .../src/components/ReviewsAndReports.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/component-manuscript/src/components/ReviewReportCard.js b/packages/component-manuscript/src/components/ReviewReportCard.js index efab0b1bd..e306ed05d 100644 --- a/packages/component-manuscript/src/components/ReviewReportCard.js +++ b/packages/component-manuscript/src/components/ReviewReportCard.js @@ -10,12 +10,12 @@ import { FileItem } from 'pubsweet-components-faraday/src/components/Files' import ShowMore from './ShowMore' const ReviewReportCard = ({ + i = 0, report = {}, journal: { recommendations }, - i = 0, }) => { const hasReviewer = !isEmpty(get(report, 'user')) - const { submittedOn, comments, user } = report + const { submittedOn, comments = [], user } = report const submittedDate = moment(submittedOn).format('DD.MM.YYYY') const publicComment = comments.find(c => c.public) const privateComment = comments.find(c => !c.public) diff --git a/packages/component-manuscript/src/components/ReviewsAndReports.js b/packages/component-manuscript/src/components/ReviewsAndReports.js index 5c447fc57..2a5b22aaf 100644 --- a/packages/component-manuscript/src/components/ReviewsAndReports.js +++ b/packages/component-manuscript/src/components/ReviewsAndReports.js @@ -47,12 +47,12 @@ const getTabSections = (collectionId, reviewers, recommendations = []) => [ const ReviewsAndReports = ({ project, version, - reviewers = [], - recommendations = [], - isReviewer, - currentUserIs, report, + isReviewer, review = {}, + currentUserIs, + reviewers = [], + recommendations = [], mappedRecommendations, }) => ( <Fragment> -- GitLab