From d9ab90db722d3c572739ffd0f4ff81ae81bf5f9e Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Thu, 15 Nov 2018 12:00:58 +0200
Subject: [PATCH] refactor(users): use switch statement instead of several ifs
---
.../src/fixtures/users.js | 36 +++++++++++--------
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/packages/component-fixture-manager/src/fixtures/users.js b/packages/component-fixture-manager/src/fixtures/users.js
index 1a6353768..aa9463a55 100644
--- a/packages/component-fixture-manager/src/fixtures/users.js
+++ b/packages/component-fixture-manager/src/fixtures/users.js
@@ -19,15 +19,29 @@ users = keys.reduce((obj, item) => {
const isHE = item === 'answerHE' || item === 'handlingEditor'
let teams = []
- if (isHE) {
- teams = [heTeamID]
- }
- if (item === 'noRecommendationHE') {
- teams = [heNoRecommendationTeamID]
- }
- if (item === 'author') {
- teams = [authorTeamID]
+ switch (item) {
+ case 'answerHE':
+ teams = [heTeamID]
+ break
+ case 'handlingEditor':
+ teams = [heTeamID]
+ break
+ case 'noRecommendationHE':
+ teams = [heNoRecommendationTeamID]
+ break
+ case 'author':
+ teams = [authorTeamID]
+ break
+ case 'reviewer1':
+ teams = [rev1TeamID]
+ break
+ case 'newReviewer':
+ teams = [revNoEditorRecommendationTeamID]
+ break
+ default:
+ teams = []
}
+
if (['reviewer', 'inactiveReviewer', 'answerReviewer'].includes(item)) {
teams.push(revTeamID)
}
@@ -35,12 +49,6 @@ users = keys.reduce((obj, item) => {
if (['reviewer', 'answerReviewer', 'recReviewer'].includes(item)) {
teams.push(revRecommendationTeamID)
}
- if (item === 'reviewer1') {
- teams = [rev1TeamID]
- }
- if (item === 'newReviewer') {
- teams = [revNoEditorRecommendationTeamID]
- }
obj[item] = {
...userData,
--
GitLab