From e0746e166c170be8fb3c13cffe23a59006e3de62 Mon Sep 17 00:00:00 2001
From: Sebastian <sebastian.mihalache@thinslices.com>
Date: Thu, 26 Apr 2018 10:54:37 +0300
Subject: [PATCH] feat(component-invite): handle get reviewers for new
manuscript
---
.../src/routes/collectionsInvitations/get.js | 7 +------
.../src/tests/collectionsInvitations/get.test.js | 8 +++-----
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/packages/component-invite/src/routes/collectionsInvitations/get.js b/packages/component-invite/src/routes/collectionsInvitations/get.js
index b4031f89f..091890fe1 100644
--- a/packages/component-invite/src/routes/collectionsInvitations/get.js
+++ b/packages/component-invite/src/routes/collectionsInvitations/get.js
@@ -25,12 +25,7 @@ module.exports = models => async (req, res) => {
models.Team,
)
- if (members === undefined) {
- res.status(400).json({
- error: `The requested collection does not have a ${role} Team`,
- })
- return
- }
+ if (members === undefined) return res.status(200).json([])
// TO DO: handle case for when the invitationID is provided
const membersData = members.map(async member => {
diff --git a/packages/component-invite/src/tests/collectionsInvitations/get.test.js b/packages/component-invite/src/tests/collectionsInvitations/get.test.js
index b92e412bf..02af456f5 100644
--- a/packages/component-invite/src/tests/collectionsInvitations/get.test.js
+++ b/packages/component-invite/src/tests/collectionsInvitations/get.test.js
@@ -74,7 +74,7 @@ describe('Get collection invitations route handler', () => {
const data = JSON.parse(res._getData())
expect(data.error).toEqual(`Role ${req.query.role} is invalid`)
})
- it('should return an error when the collection does not have a the requested role team', async () => {
+ it('should return success with an empty array when the collection does not have a the requested role team', async () => {
const { editorInChief, handlingEditor } = testFixtures.users
const { collection } = testFixtures.collections
const req = httpMocks.createRequest()
@@ -87,10 +87,8 @@ describe('Get collection invitations route handler', () => {
req.user = editorInChief.id
const res = httpMocks.createResponse()
await require(getPath)(models)(req, res)
- expect(res.statusCode).toBe(400)
+ expect(res.statusCode).toBe(200)
const data = JSON.parse(res._getData())
- expect(data.error).toEqual(
- `The requested collection does not have a ${req.query.role} Team`,
- )
+ expect(data).toHaveLength(0)
})
})
--
GitLab