From e8e3ae1809d5d45e6778f987f913e2678a5c938c Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebastian.mihalache@gmail.con>
Date: Wed, 2 May 2018 10:58:44 +0300
Subject: [PATCH] fix(component-user-manager): fix missing params return
---
.../src/routes/collectionsUsers/post.js | 8 ++------
.../src/tests/collectionsUsers/post.test.js | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/packages/component-user-manager/src/routes/collectionsUsers/post.js b/packages/component-user-manager/src/routes/collectionsUsers/post.js
index 36ed33c02..73957c570 100644
--- a/packages/component-user-manager/src/routes/collectionsUsers/post.js
+++ b/packages/component-user-manager/src/routes/collectionsUsers/post.js
@@ -1,4 +1,3 @@
-const logger = require('@pubsweet/logger')
const get = require('lodash/get')
const helpers = require('../../helpers/helpers')
const collectionHelper = require('../../helpers/Collection')
@@ -10,11 +9,8 @@ module.exports = models => async (req, res) => {
if (
!helpers.checkForUndefinedParams(email, role, isSubmitting, isCorresponding)
- ) {
- res.status(400).json({ error: 'Email and role are required' })
- logger.error('Email and role are missing')
- return
- }
+ )
+ return res.status(400).json({ error: 'Missing parameters.' })
const collectionId = get(req, 'params.collectionId')
let collection
diff --git a/packages/component-user-manager/src/tests/collectionsUsers/post.test.js b/packages/component-user-manager/src/tests/collectionsUsers/post.test.js
index 14642466d..6d1b34621 100644
--- a/packages/component-user-manager/src/tests/collectionsUsers/post.test.js
+++ b/packages/component-user-manager/src/tests/collectionsUsers/post.test.js
@@ -87,7 +87,7 @@ describe('Post collections users route handler', () => {
expect(res.statusCode).toBe(400)
const data = JSON.parse(res._getData())
- expect(data.error).toEqual('Email and role are required')
+ expect(data.error).toEqual('Missing parameters.')
body.email = author.email
})
it('should return an error when the role is not author and the user exists', async () => {
--
GitLab