Skip to content

fix: duplicate identify crashes server

Duncan Bennett requested to merge 859-duplicate-identity-crashes-server into main

Refactors "createOAuthIdentity" so that it awaits "Identity.insert". This fixes two problems:

  • it guarantees that a new Identity is created before returning from "createOAuthIdentity"; previously it would return a promise which would probably be resolved at the graphql level.
  • it guarantees that all error handling occurs within "createOAuthIdentity" and this seems to be enough to avoid crashing the application.

Related to https://gitlab.coko.foundation/ketida/ketida/-/issues/859

Edited by Duncan Bennett

Merge request reports