Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
pubsweet
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Container Registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Giorgio Sironi
pubsweet
Commits
dd8b58d1
Commit
dd8b58d1
authored
7 years ago
by
Alf Eaton
Browse files
Options
Downloads
Patches
Plain Diff
Improve file uploading
parent
17c076cc
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/molecules/Files.js
+6
-2
6 additions, 2 deletions
src/molecules/Files.js
src/molecules/Upload.js
+9
-1
9 additions, 1 deletion
src/molecules/Upload.js
with
15 additions
and
3 deletions
src/molecules/Files.js
+
6
−
2
View file @
dd8b58d1
...
@@ -36,9 +36,13 @@ class Files extends React.Component {
...
@@ -36,9 +36,13 @@ class Files extends React.Component {
url
url
})
})
this
.
setState
({
values
})
const
uploads
=
this
.
state
.
uploads
.
filter
(
item
=>
{
return
item
.
file
.
name
!==
file
.
name
})
this
.
setState
({
values
,
uploads
})
this
.
props
.
handle
Change
(
values
)
this
.
props
.
on
Change
(
values
)
}
}
render
()
{
render
()
{
...
...
This diff is collapsed.
Click to expand it.
src/molecules/Upload.js
+
9
−
1
View file @
dd8b58d1
...
@@ -16,8 +16,10 @@ class Upload extends React.Component {
...
@@ -16,8 +16,10 @@ class Upload extends React.Component {
request
.
addEventListener
(
'
progress
'
,
this
.
handleProgress
)
request
.
addEventListener
(
'
progress
'
,
this
.
handleProgress
)
request
.
addEventListener
(
'
load
'
,
this
.
handleLoad
)
request
.
addEventListener
(
'
load
'
,
this
.
handleLoad
)
request
.
addEventListener
(
'
error
'
,
this
.
handleError
)
request
.
addEventListener
(
'
error
'
,
this
.
handleError
)
request
.
addEventListener
(
'
abort
'
,
this
.
handleAbort
)
}
}
// TODO: 'progress' event not being fired often enough?
handleProgress
=
event
=>
{
handleProgress
=
event
=>
{
if
(
!
event
.
lengthComputable
)
return
if
(
!
event
.
lengthComputable
)
return
...
@@ -43,12 +45,18 @@ class Upload extends React.Component {
...
@@ -43,12 +45,18 @@ class Upload extends React.Component {
}
}
}
}
handlError
=
event
=>
{
handl
e
Error
=
event
=>
{
this
.
setState
({
this
.
setState
({
error
:
'
There was an error
'
error
:
'
There was an error
'
})
})
}
}
handleAbort
=
event
=>
{
this
.
setState
({
error
:
'
The upload was cancelled
'
})
}
render
()
{
render
()
{
const
{
file
}
=
this
.
props
const
{
file
}
=
this
.
props
const
{
progress
,
error
}
=
this
.
state
const
{
progress
,
error
}
=
this
.
state
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment