fix: resolve remaining jsx-a11y lint issues

.eslintrc

@@ -19,10 +19,6 @@
       "enforceForRenamedProperties": false
     }],
     "global-require": 0,
-    "jsx-a11y/anchor-is-valid": 0,
-    "jsx-a11y/click-events-have-key-events": 0,
-    "jsx-a11y/label-has-for": 0,
-    "jsx-a11y/no-static-element-interactions": 0,
     "import/no-dynamic-require": 0,
     "import/no-extraneous-dependencies": 0,
     "import/no-named-as-default": 0,

packages/components/packages/Blog/Blog.jsx

@@ -39,7 +39,7 @@ export default class Blog extends React.Component {
             <Row className={styles.hero}>
               <Col md={8} mdOffset={2}>
                 <h1>Welcome to {this.props.blog && this.props.blog.title}</h1>
-                <label>Science for the Web</label>
+                <p>Science for the Web</p>
               </Col>
             </Row>
           </Grid>

packages/components/packages/Blog/Summary.jsx

+/* eslint-disable jsx-a11y/anchor-is-valid */
+
 import React from 'react'
 import PropTypes from 'prop-types'
 import { Row, Col } from 'react-bootstrap'

packages/components/packages/Navigation/Navigation.jsx

@@ -10,7 +10,7 @@ const Navigation = ({ actions, currentUser }) => (
   <Navbar fluid>
     <Navbar.Header>
       <NavbarBrand>
-        <a href="#">
+        <a href="/">
           <img alt="pubsweet" src="/pubsweet.jpg" />
         </a>
       </NavbarBrand>

packages/ui/src/molecules/AppBar.js

@@ -4,6 +4,7 @@ import PropTypes from 'prop-types'
 
 import th from '../helpers/themeHelper'
 import { Icon, Link } from '../atoms'
+import PlainButton from './PlainButton'
 
 // #region styled-components
 const Root = styled.nav`
@@ -80,10 +81,10 @@ const DefaultRightComponent = ({ user, onLogoutClick, loginLink }) => (
 
     {user && (
       <Item>
-        <Link onClick={onLogoutClick} to="#">
+        <PlainButton onClick={onLogoutClick}>
           <Icon size={2}>power</Icon>
           Logout
-        </Link>
+        </PlainButton>
       </Item>
     )}
 

packages/ui/test/__snapshots__/AppBar.test.js.snap

@@ -106,8 +106,15 @@ exports[`AppBar With admin user 1`] = `
 }
 
 .c6 {
+  background: none;
+  border: none;
+  padding: 0;
   color: black;
+  -webkit-text-decoration: underline;
+  text-decoration: underline;
   cursor: pointer;
+  font-family: inherit;
+  font-size: inherit;
 }
 
 .c0 {
@@ -215,10 +222,10 @@ exports[`AppBar With admin user 1`] = `
     <span
       className="c4"
     >
-      <a
+      <button
         className="c6"
-        href="#"
         onClick={[Function]}
+        type={undefined}
       >
         <span
           className="c5"
@@ -249,7 +256,7 @@ exports[`AppBar With admin user 1`] = `
           </svg>
         </span>
         Logout
-      </a>
+      </button>
     </span>
   </div>
 </nav>