Merge branch 'fix-set-state' into 'master'

Fix react/no-did-mount-set-state lint error

See merge request pubsweet/pubsweet!28

.eslintrc

@@ -35,7 +35,6 @@
     "no-shadow": 0,
     "no-underscore-dangle": 0,
     "react/forbid-prop-types": 0,
-    "react/no-did-mount-set-state": 0,
     "react/no-unused-prop-types": 0,
     "react/no-unused-state": 0,
     "react/prop-types": 0,

packages/client/src/components/UpdateSubscriber.jsx

@@ -30,7 +30,7 @@ export class UpdateSubscriber extends Component {
     this.listeners = {}
   }
 
-  componentDidMount() {
+  componentWillMount() {
     this.subscribe(this.props)
     this.setState({ visible: UpdateSubscriber.visible() })
   }

packages/client/test/components/UpdateSubscriber.test.jsx

@@ -7,12 +7,9 @@ import { UpdateSubscriber } from '../../src/components/UpdateSubscriber'
 global.PUBSWEET_COMPONENTS = []
 
 function makeWrapper(props = {}) {
-  const wrapper = shallow(
+  return shallow(
     <UpdateSubscriber currentUser={{}} handleUpdate={jest.fn()} {...props} />,
   )
-  // did* lifecycle methods don't get automatically called on shallow render
-  wrapper.instance().componentDidMount()
-  return wrapper
 }
 
 describe('<UpdateSubscriber/>', () => {