feat(manuscript): use submission field as a pure JSON blob to simplify changing forms

app/components/component-xpub-submit/src/components/SubmitPage.js

@@ -90,6 +90,7 @@ const fragmentFields = `
     email
     affiliation
   }
+  submission
 `
 
 const query = gql`
@@ -237,7 +238,10 @@ export default compose(
   })),
   withFormik({
     initialValues: {},
-    mapPropsToValues: ({ manuscript }) => manuscript,
+    mapPropsToValues: ({ manuscript }) =>
+      Object.assign({}, manuscript, {
+        submission: JSON.parse(manuscript.submission),
+      }),
     displayName: 'submit',
     handleSubmit: (
       props,

server/manuscript/src/manuscript.js → server/model-manuscript/src/manuscript.js

@@ -248,10 +248,12 @@ class Manuscript extends BaseModel {
             keywords: { type: ['string', 'null'] },
           },
         },
+        submission: {},
       },
     }
   }
 
+  // TODO: Do this on the DB level with cascading deletes
   async $beforeDelete() {
     // const Review = require('../../review/src/review')
     const { Review, Team, File } = require('@pubsweet/models')

server/manuscript/src/migrations/1537450834-manuscript.sql → server/model-manuscript/src/migrations/1537450834-manuscript.sql

@@ -8,5 +8,6 @@ CREATE TABLE manuscripts (
     authors JSONB,
     suggestions JSONB,
     meta JSONB,
+    submission JSONB,
     type TEXT NOT NULL
 );
\ No newline at end of file

server/manuscript/src/resolvers.js → server/model-manuscript/src/resolvers.js

@@ -7,6 +7,13 @@ const resolvers = {
       const { Team } = require('@pubsweet/models')
 
       const { meta, files } = vars.input
+
+      // We want the submission information to be stored as JSONB
+      // but we want the input to come in as a JSON string
+      const submission = vars.input.submission
+        ? JSON.parse(vars.input.submission)
+        : {}
+
       const emptyManuscript = {
         meta: Object.assign(meta, {
           notes: [
@@ -21,7 +28,9 @@ const resolvers = {
           ],
         }),
         status: 'new',
+        submission,
       }
+
       // eslint-disable-next-line
       const manuscript = await new ctx.connectors.Manuscript.model(
         emptyManuscript,
@@ -173,6 +182,14 @@ const resolvers = {
       return form
     },
   },
+  // We want submission into to come out as a stringified JSON, so that we don't have to
+  // change our queries if the submission form changes. We still want to store it as JSONB
+  // so that we can easily search through the information within.
+  Manuscript: {
+    submission(parent, args, ctx) {
+      return JSON.stringify(parent.submission)
+    },
+  },
 }
 
 module.exports = resolvers

server/manuscript/src/typeDefs.js → server/model-manuscript/src/typeDefs.js

@@ -27,6 +27,7 @@ const typeDefs = `
     suggestions: Suggestions
     authors: [Author]
     meta: ManuscriptMeta
+    submission: String
   }
 
   type ManuscriptVersion implements Object {
@@ -42,11 +43,13 @@ const typeDefs = `
     suggestions: Suggestions
     authors: [Author]
     meta: ManuscriptMeta
+    submission: String
   }
 
   input ManuscriptInput {
     files: [FileInput]
     meta: ManuscriptMetaInput
+    submission: String
   }
 
   input ManuscriptMetaInput {