Displaying a 404 error
Expected behaviour
For multi-tenanted instances, the Favicon should not display for root login page.
Current behaviour
Favicon should only display per group kotahi/flax pages.
Steps to reproduce
visit; http://sciety.kotahi.cloud/
Environment
Issue only displays when the favicon has been cached by the browser.
Possible solution
Feedback from Ben
I believe the reason that favicon is stuck in your cache, even after hard refresh (Ctrl-F5), is because Kotahi is not returning an HTTP 404 error as it should when the favicon is requested, but instead returns an HTML webpage and HTTP code 200 (which means "OK", successfully delivered). Because this is not an image file as expected, the browser assumes that the favicon may still exist but is temporarily inaccessible due to some server error. So it retains the icon it has cached. It will not drop the favicon from its cache unless it gets a 404 "Not found" error, which tells it unambiguously that the favicon doesn't exist.
We should correctly return a HTTP 404 response for any page or asset requested which does not exist. Currently, any non-existent page or asset will always return a blank HTML page (and some javascript) with status 200.