Skip to content

Aperture test fixes

Sidorela Uku requested to merge aperture-test-fixes into main

This MR includes fixes on the aperture test after the changes which are done in the main dashboard by fixing the steps and actions.

Few things noted:

  • There where two test to check the status of manuscript from the dashboard, by checking how many reviewers approved/rejected/accepted. Now that information is visualised with a graph. This makes the test to fail as it was checking for text. This needs an alternative solution maybe by checking the attributes of the image.

  • Again there are more tests failing in pipeline than locally with the communication error in dashboard (this only happens when the dashboard had to show manuscript content related with the user).

Type 1:
error: manuscriptHasOverdueTasksForUser is not a function message=manuscriptHasOverdueTasksForUser is not a function, locations=[line=9, column=3], path=[manuscriptsUserHasCurrentRoleIn], code=INTERNAL_SERVER_ERROR, stacktrace=[TypeError: manuscriptHasOverdueTasksForUser is not a function, at /home/node/app/server/model-manuscript/src/graphql.js:1297:50, at Array.forEach (<anonymous>), at manuscriptsUserHasCurrentRoleIn (/home/node/app/server/model-manuscript/src/graphql.js:1279:30), at processTicksAndRejections (internal/process/task_queues.js:97:5), at async middleware (/home/node/app/node_modules/graphql-shield/dist/generator.js:30:24)]

Type 2:
error: manuscriptIsActive is not a function message=manuscriptIsActive is not a function, locations=[line=2, column=3], path=[updateTeam], code=INTERNAL_SERVER_ERROR, stacktrace=[TypeError: manuscriptIsActive is not a function, at updateAlertsUponTeamUpdate (/home/node/app/server/model-task/src/taskCommsUtils.js:111:15), at updateTeam (/home/node/app/server/model-team/src/graphql.js:58:15), at runMicrotasks (<anonymous>), at processTicksAndRejections (internal/process/task_queues.js:97:5), at async middleware (/home/node/app/node_modules/graphql-shield/dist/generator.js:30:24)]

Note: this is marked as ready based on the status of the tests locally which pass. The issue with failure in pipeline will be handled on a separate MR.

Edited by Sidorela Uku

Merge request reports