Reviewer redesign feedback

changed the description

I insert the reviewer info but I would like to add to the list, not send an invitation right away. The button below says send invitation. Would be better that the button said “add to list”. Once that reviewer is in the list, the editor can rearrange reviewers and then start the automation. (need @karenyook’s feedback when she will be back from vacation)

I thought about that, but I just decided to keep it working as it did before. So the way you're proposing, it would add them to the pool and not send an email. From then on, when (and if) you invite them, they receive the email that currently would have.

Once I start the automation I cannot add reviewers in the ‘Invite a reviewer that is not a user yet’. We should allow that as we might receive additional names while the system is running. Possible to allow it?

It is possible if we implement the previous comment. What we don't want is to send out an invitation while the max number of reviewers has already been reached.

When I entered a reviewer there (‘Invite a reviewer that is not a user yet’) I did not receive an invitation but I did receive a notification when the invitation was revoked.

the cron seems not to be working. When I start the automation I do not receive reminder emails, waited 12 min now.

@nickstiffler is there any useful logs for the above?

I thought about that, but I just decided to keep it working as it did before. So the way you're proposing, it would add them to the pool and not send an email. From then on, when (and if) you invite them, they receive the email that currently would have.

Correct

Once I start the automation I cannot add reviewers in the ‘Invite a reviewer that is not a user yet’. We should allow that as we might receive additional names while the system is running. Possible to allow it?

It is possible if we implement the previous comment. What we don't want is to send out an invitation while the max number of reviewers has already been reached.

ok

changed milestone to %Next

added bug label

added feature label

This is odd. There are no logs files. Just an empty logs/development.

I see a few instances of this error in the console:

error: Add external reviewer: Transaction failed! Rolling back...
error: Error: Add external reviewer: No available reviewer slots
{ error:
   { message: 'Error: Add external reviewer: No available reviewer slots',
     locations: [ { line: 2, column: 3 } ],
     path: [ 'addExternalReviewer' ],
     extensions:
      { code: 'INTERNAL_SERVER_ERROR',
        exception:
         { stacktrace:
            [ 'Error: Error: Add external reviewer: No available reviewer slots',
              '    at addExternalReviewer (/home/stiffler/micropub-dev/server/api/team/team.resolver.js:95:11)',
              '    at process._tickCallback (internal/process/next_tick.js:68:7)' ] } } } }

let us know when we can test again

Logs seem to work fine for me @nickstiffler. Keep in mind that in development, writing logs to a file is commented out (in config/development.js).

On the error, please give me:

The value of manuscriptVersion.reviewerPool for that particular version
The values of the team members for that version (something along the lines of the following)

await TeamMember.query()
.where({
    objectId: manuscriptVersionId,
    role: 'reviewer'
})

I didn't realize that about the log files.

The user ids in reviewerPool match the user ids in the team members:

Reviewer pool:

["e813b3be-ca75-4ecd-a83b-1331f2f930d5", "ef289527-c076-44f0-bb3c-43fc075171ec"]

Team members:

                  id                  |          created           |          updated           | status  |               team_id                |               user_id                
--------------------------------------+----------------------------+----------------------------+---------+--------------------------------------+--------------------------------------
 7d499236-195d-4f25-944e-f56cc6cbc1c7 | 2021-04-23 22:37:42.169+00 | 2021-04-23 22:39:05.258+00 | invited | dbd4341d-e877-42f0-aefe-08c6747e0ba5 | e813b3be-ca75-4ecd-a83b-1331f2f930d5
 72e756a3-66a8-4e83-819c-bff4a6018522 | 2021-04-23 22:37:46.644+00 | 2021-04-23 22:53:27.102+00 | invited | dbd4341d-e877-42f0-aefe-08c6747e0ba5 | ef289527-c076-44f0-bb3c-43fc075171ec

A few comments: https://gitlab.coko.foundation/micropublication/micropublication/-/blob/master/server/services/cron/onDemand/_jobs.js#L46 It looks like revoke is working, but the notification is disabled. The UI needs to be reloaded to see it.

https://gitlab.coko.foundation/micropublication/micropublication/-/blob/master/server/services/cron/onDemand/_jobs.js#L20 This looks like a bug because it should be false when the reviewer has not yet accepted.

https://gitlab.coko.foundation/micropublication/micropublication/-/blob/master/server/services/cron/onDemand/_jobs.js#L18 If isAccepted, the duration should be only 3 days.

Have all of these been addressed by !310 (merged)?

mentioned in merge request !310 (merged)

@nickstiffler reporting it here so also @yannis is in the loop.

the email notification reminders still seem not to be working for me. What I did:

I tested the reviewer system on dev
I started the automation (selected 1 reviewer at a time)
I received initial invite but I still did not receive a reminder email
The system did not move on to the next reviewer

The second email goes out just fine for me.

@nickstiffler I just pushed a change to master that adds an entry to the logs every time an email is sent out so that you can debug and audit easier.

The second email seems to be sent to the editors though. (through the isAccepted logic that is there)

Just a reminder that @yannis has pretty much done all his hours (more than) on the project. He will stop work on micropubs completely in a week or so. @nickstiffler @draciti

@adam duly noted. I did not realize it was so soon @nickstiffler @yannis @karenyook shall we have a final call next Wednesday at our usual time for our own goodbyes and wrap up?

haha :) so soon! its only been 3 years ;) its a pity to see it come to and end but the good news is the platform looks awesome :)

assigned to @yannis

changed milestone to %Wrap up

unassigned @yannis

Reviewer redesign feedback

Designs

Child items 0

Activity