Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • N ncbi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 265
    • Issues 265
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ncbi
  • ncbi
  • Issues
  • #1184

Closed
Open
Created Apr 21, 2022 by Diana jordan@jordandcGuest

can preview and publish with emtpy "Book source type"

@lathrops1

Expected behaviour

Introduce a warning if try to submit, publish or reload to preview a book that doesn't have a "Book source type" filled in in metadata.

Current behaviour

In Whole book, can preview and publish with empty Book source type in metadata modal.

Steps to reproduce

https://ncbi.cloud68.co/organizations/ef36c5c4-d9a7-4188-9254-c61c520fd21f/bookmanager/be7ebf70-fc29-4a5a-85f2-b4ed66eb26b1/ac429f0c-52a6-470d-adcc-0f39bcf868e2

  1. create whole xml book
  2. manually upload source file (and related suppl/images)
  3. submit and wait for preview
  4. got to bookmeta modal - see that "Book source type" is empty

NCBI's priority feedback

Book source type MUST be a REQUIRED FIELD - if somehow it goes missing during processing or migration it could break Bookshelf front end.

Proposed solution

  • Make Book source type a required field in collection set up, so books in collections inherit the value correctly (that is done by #1217 (closed))
  • Make Book source type a required field before submitting files, loading to preview, or publishing. When a user selects 'Submit', 'Reload preview' or 'Publish', if the Book source type is not present in metadata, a popup appears which says: 'Complete the required 'Book Source type' field in the Book Metadata, and then come back to this action.'

QA Steps

[To be completed by Coko once dev is done]

Edited Jul 18, 2022 by ChristinaTromp
Assignee
Assign to
Time tracking