Don't run Coko checks on metadata before saving uploaded converted file
Expected behaviour
Per specifications - https://docs.google.com/spreadsheets/d/1M4ZdBbzr2s4-PUXqEblfsKoPBUuk4aG343u9ZAUn_Tk/edit#gid=625909583
User should be able to upload valid converted xml files to new books. NCBI's converted BXML files for migration include two DTDs:
Current behaviour
User is unable to upload valid converted BITS xml file to new book, because the upload is blocked when a Coko check on pub date
fails even though the file loads successfully from NCBI Silverlight CMS.
Steps to reproduce
See recording: video1575604341
Book recorded: https://ncbi.cloud68.co/organizations/308db55a-21c9-4a64-9a70-d5aa7574726c/bookmanager/31a23f23-aaac-49e8-abf4-f0bc23b006cd
Test files resupplied in #1475 (comment 108986) bcms6772.590b65.2023_02_03-08_48_39.output.zip
Environment
Agreed solution
Remove Coko checks on metadata that would prevent ANY converted XML in the BITS or NLM 2.3 DTD from being sent to load to PMC so that all errors are reported to user / system admin to know how to report to successfully fix the errors.
Note, Coko should still validate all XML THEY WRITE against the BITS DTD and PMC style checker to ensure it is valid against the DTD and PMC style compliant, and there should be a process for fixing any errors against those NCBI supported scripts as part of any Coko maintenance.
Caveat
- NCBI acknowledges if we remove checks when saving data, this is likely to lead to errors down the line when the BCMS writes book metadata (in the case of TOCs)
- We agree to follow a clear process to resolve these errors, summarized below:
- BCMS runs ALL XML IT WRITES against the PMC Style checker - see #1643
- If XML that the BCMS writes fails the PMC Style checker, a bug is immediately issued and triaged as maintenance
- In all other cases if there are XML issues, NCBI identifies which aspect of metadata is causing an error
- NCBI reproduces the case on ncbi.cloud68.co if it doesn't already exist there.
- NCBI opens a "Metadata feature extension" issue with the relevant information
- Coko team reviews and estimates the issue for development
- Coko/NCBI teams review scope, sign off, and schedule in the dev cycle according to priority.
QA Steps
[To be completed by Coko once dev is done]
Scheduling
Possible alternatives
Provide all possible pub date
types to save as accepted values so that Coko's existing check can remain.