Pre-calculate values to improve book manager performance and remove unneeded query
Context
The context is described in the Epic description: &106. Coko team investigated additional backend improvements to improve book manager performance.
Proposal
Pre-calculate the following:
- The value for TOC tags: 'repeat' and 'exclude'
- Error detail for values: 'publisher' or 'PMC'
Remove:
The In review status – we should close this query since it’s not supported for MVP. Currently the functionality is only hidden in the frontend.
Acceptance criteria
-
Compare the current logs to the new logs to show the improvement on the postgres queries. -
Save "In Review" query in separate branch for future use.
Note: the performance from the users perspective will be tested after all linked items are complete
Log for NCBI developers' review:
Logs of postgresql queries and graphql Requests before and after removing the unneeded queries:
postgresql-before-remove-queries.log
loading-time-after-removing-queries
postgresql-after-remove-queries.log
loading-time-before-remove-queries
Brach with saved "In review" code
https://gitlab.coko.foundation/ncbi/ncbi/-/tree/remove-review-backend
Definition of ready
-
BCMS User Story / Context has been well defined -
The priority of the user story is specified and agreed -
Digital assets added (design, database scheme, mockups etc if relevant) -
Coko Technical Proposal approved by NCBI -
Testable Acceptance Criteria approved by NCBI -
Estimate of effort to complete (time or points) -
The issue has been broken down into development tasks (if necessary) -
Requirements Clarified -
The product owner and development team agree that the user story is ready for development -
NCBI adds “Dev_Ready”
Definition of done
-
All coding tasks are finished and implemented -
QA approved -
Deployed and tested on “ncbidev” (by Coko team) -
Deployed and tested on “ncbi” (by NCBI team) -
Acceptance Criteria Met
Implementation
Alternative approaches (if applicable)
Scheduling
-
Milestone is linked -
Iteration is linked -
Dependencies: none -
Development estimate is added to issue time tracking