Login and register pages Refactor
We need to refactor code in the login and register page before we go on with other features. Here is a list of what i think needs to be changed:
-
Use the TextFieldComponent
for all text fields , in case the current component does not fit, improve that component to be adjustable for all cases we use it. -
RemeberMeCheckbox
is redundant, as we already have on checkbox -
SubmitButton
is just a normal button, no need for new component -
graphql folder inside Login folder should only contain index.js file with all mutations and queries (as there is no sense separating them when we don't have many queries and mutations) -
Same issues in Register page -
if the Register is working fine we can delete the Signup folder -
Check all styled components in login and register folders to make sure we have used theme variables. ex fixed numbers in pixels should be only inn gridUnit
* or / a number to where we need it.
Functionality issues :
* [ ] If you are in a page and the session has expired , it should redirect to Login page, in this state where the app is, it just hides the menu making it impossible for a normal user to go to login page, the only way is by adding /login to url
-
Can you try to do remember me functionality (see this link) -
in login page , after you type password, when pressing enter key (from keyboard) should trigger the submit button, it used to work like that before , and it usually does in all apps
@DioneMentis the list of UI components we share in different pages is :
- Form elements
- Toggle, Input fields, Selects, Checkbox, Icon buttons
- Composite Elements
- Status (book component status,book status and file statuses ), Source File Icons, Date component (in human readable format as in dashboard example),Pages Filter, Tabs and Accordions
- App bar, Second navigation bar, Footer Action bar
I think once these ui elements as finished and cover all our cases, we will be just re-using them and won't have conflicts working in different pages, some of them may just need changes in the styles, some may need to be redone as some elements that we use pubsweet may not be extendable enough for our needs