Skip to content
Snippets Groups Projects

Implement --timeout option

Merged Boris Budini requested to merge timeout into master

Passes the -t/--timeout option from the command line to the printer, and uses it to set the timeout when puppeteer is loading pages.

See #28, #37

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I would really like if somebody could merge this request in ASAP, since I'm currently printing out a large document on a build server and facing 30 seconds limitation.

    By mykola.klymyuk on 2021-05-14T21:14:43 (imported from GitLab)

  • @fchasen we need you here!

    By mykola.klymyuk on 2021-05-14T21:23:55 (imported from GitLab)

  • merged

    By Fred Chasen on 2021-05-16T19:28:50 (imported from GitLab)

  • Boris Budini mentioned in commit f6b3b46a

    mentioned in commit f6b3b46a

    By Fred Chasen on 2021-05-16T19:28:51 (imported from GitLab)

  • Sorry! Thanks for this, great updated.

    By Fred Chasen on 2021-05-16T19:29:24 (imported from GitLab)

  • Thanks a lot @fchasen !Not sure how npm deals with versioning, but I believe a package version should be bumped up (probably to 0.1.2) to make the new package version available on npm. Could you (or somebody with write permissions) please also update the package version?

    By mykola.klymyuk on 2021-05-16T21:04:24 (imported from GitLab)

  • Got a few more merges to get in so will release the new version on Monday.

    By Fred Chasen on 2021-05-16T21:46:01 (imported from GitLab)

  • @fchasen many thanks!

    By mykola.klymyuk on 2021-05-17T08:22:40 (imported from GitLab)

Please register or sign in to reply