Add a possibility to pass extra arguments to puppeteer
Merge request reports
Activity
added 1 commit
- 77ef1248 - Pass to puppeteer any set of additional arguments
By Myroslava on 2020-12-09T13:39:35 (imported from GitLab)
To add one piece of context for why this is useful: by default, Puppeteer tries to create a sandbox, and therefore requires passing an argument such as
--security-opt 'seccomp=seccomp.json'in order to run inside Docker, as the README mentions. Amazon ECS does not currently support passing this argument, and as such, it is not currently possible to run paged-cli on ECS.This issue can be avoided by passing the
--no-sandboxflag to Puppeteer. This PR would allow passing this flag, and would also generally make it easier to run paged-cli in more contexts, as long as those contexts are supported by Puppeteer itself.By Gal Niv on 2021-01-25T19:03:52 (imported from GitLab)
-
This totally makes sense. Thanks for the PR.
I believe that @fchasen has some backlog to catch up, but this should definitely makes it way to the code.
By julien on 2021-01-25T19:03:52 (imported from GitLab)
mentioned in merge request !20 (merged)
By Fred Chasen on 2021-05-18T05:55:51 (imported from GitLab)
-
I somehow merged this without out the changes locally, I've recreated the changed and merged them again in https://gitlab.pagedmedia.org/tools/pagedjs-cli/merge_requests/20
Sorry about that, very strange!
By Fred Chasen on 2021-05-18T05:57:46 (imported from GitLab)