|
|
|
## April 10, 2018
|
|
|
|
|
|
|
|
- Decide on the use of naming convention with gridUnit on the starter-kit (check below)
|
|
|
|
- Subgrid: decide if we stick to the smaller unit grid system or on a line-height based grid.
|
|
|
|
- Update on buttons (#19) and discuss next element to design.
|
|
|
|
- update on buttons: @julientaq can show example of states for the buttons and how it could be implemented on the theme if we all agreed. (simple `box-shadow` and animation on clic).
|
|
|
|
- Animation variable, how @julientaq struggle to implement those (this can wait for further discussion).
|
|
|
|
|
|
|
|
## April 3, 2018
|
|
|
|
|
|
|
|
### Agenda
|
|
|
|
* Sub grid - do we need to set these values
|
|
|
|
* Vertical space. Should we be setting our line-height based on our smallest measure rather line height (8px for instance)? What are the pros and cons?
|
|
|
|
|
|
|
|
### Meeting notes
|
|
|
|
|
|
|
|
#### Subgrid
|
|
|
|
|
|
|
|
Idea is to set the minimal value for the grid on the smallest increment to stick to only keep one maths formula (you don't have to mix division and multiplies). Therefore, the `$fontLineHeight` will be set as a calculation (`$fontLineHeight = $gridUnit * 4`), this is still pending as the meeting was shortened. For example, this is the code for the button, which mixes multiply, division, `gridUnit` and `subGridUnit`:
|
|
|
|
|
|
|
|
```javascript
|
|
|
|
min-width: calc(${th('gridUnit')} * 4);
|
|
|
|
height: calc(${th('gridUnit')} * 2);
|
|
|
|
padding: 0 calc(${th('gridUnit')} / 4);
|
|
|
|
margin-right: ${th('subGridUnit')};
|
|
|
|
|
|
|
|
```
|
|
|
|
|
|
|
|
###Naming convention for `gridUnit`
|
|
|
|
|
|
|
|
Idea is to use simple words to define the amount of space between elements. For example:
|
|
|
|
| word | calculation (using 8px as `GridUnit`) | notes |
|
|
|
|
|---|---|---|
|
|
|
|
| `xs` | `$gridUnit / 2` | |
|
|
|
|
| `sm` |`$gridUnit` | |
|
|
|
|
| `md` | `$gridUnit * 2` | |
|
|
|
|
|`default`| `$gridUnit * 4` | same as `$fontLineHeight`|
|
|
|
|
| `lg` | `$gridUnit * 8` | |
|
|
|
|
| `xl` | `$gridUnit * 16` | |
|
|
|
|
|
|
|
|
For now, it seems that it's not needed by all the stakeholders, and thus should not be implemented in the starter-kit. This need to be decided on the next meeting
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
## March 29, 2018
|
|
|
|
|
|
|
|
### Agenda
|
| ... | ... | |