RFC: review protocol
Review are functioning in a more-or-less timely matter atm, but I'm anticipating problems as more people start contributing over the next few weeks. I think, regardless, a clear protocol would be useful. Proposal:
- An MR is mergeable by anyone if it has two reviews, one within org., one outside org.
- The weekly includes a review of outstanding MRs. If any MRs are older than one week, someone is assigned to review them the same day.
- WIP vs. non-WIP is confusing, makes it unclear when an MR should be reviewed, and leads to MRs hanging around too long. Any open MR should be considered as a merge candidate and the reviewer should comment as to mergebility or otherwise.
- Reviewers should strive to be clear about whether a comment is a thought/preference or definitely requires change before for merging.
- Reviewers should use the 'merge when pipeline completes' checkbox when appropriate (although having a clear protocol actually makes this less important).