Skip to content
Snippets Groups Projects
Commit 19a07b33 authored by Christos's avatar Christos
Browse files

Update CONTRIBUTING.md

parent d828906b
No related branches found
No related tags found
1 merge request!42Patch 1
...@@ -27,14 +27,9 @@ This is a two part process, first ask for comments, then ask for the changes to ...@@ -27,14 +27,9 @@ This is a two part process, first ask for comments, then ask for the changes to
Ask for feedback generate a Merge Request (Pull Request) from the GitLab interface but do not assign this request to anyone. You do this from the Gitlab Ask for feedback generate a Merge Request (Pull Request) from the GitLab interface but do not assign this request to anyone. You do this from the Gitlab
UI on your branch. UI on your branch.
Look at the feedback and alter your branch as necessary. Look at the feedback and alter your branch as necessary.
To merge with master - generate a merge request (Pull Request) and assign to Jure Triglav. You do this from the Gitlab UI on your branch. To merge with master - generate a merge request (Pull Request). You do this from the Gitlab UI on your branch.
We encourage feedback and discussion from as many people as possible on Merge Requests! We encourage feedback and discussion from as many people as possible on Merge Requests!
Before merging all PRs must fulfill these three simple rules:
1. Before a PR can be merged, it must pass the tests and CI.
2. Before a PR can be merged, it shouldn't reduce the test coverage.
3. Bugfixes go in PRs and a bugfix PR shouldn't be merged without a regression test.
## Conventional commits ## Conventional commits
...@@ -43,7 +38,7 @@ We use conventional commits and verify that commit messages match the pattern, y ...@@ -43,7 +38,7 @@ We use conventional commits and verify that commit messages match the pattern, y
## Bug reports, feature requests, support questions ## Bug reports, feature requests, support questions
This is all done through GitLab using their native issue tracker This is all done through GitLab using their native issue tracker
Visit the master issue tracker for PubSweet (https://gitlab.coko.foundation/pubsweet/pubsweet/issues) Visit the master issue tracker for PubSweet (https://gitlab.coko.foundation/wax/wax-prosemirror/issues)
Add an issue Add an issue
Tag the issue with 'support', 'bug', or 'feature' to identify the nature of your issue Tag the issue with 'support', 'bug', or 'feature' to identify the nature of your issue
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment