Skip to content
Snippets Groups Projects
Commit 2bc93ebb authored by chris's avatar chris
Browse files

add TODO's

parent 4b958fcb
No related branches found
No related tags found
1 merge request!128add TODO's
......@@ -67,7 +67,7 @@ export default ({ comment, activeView, user }) => {
// saveComment();
}
// TODO Also find fragmented marks
// TODO pass correct comment pos for notes
if (conversation.length === 0 && value === '') {
const commentPosition = DocumentHelpers.findMarkPosition(activeView, comment.pos, 'comment');
dispatch(state.tr.removeMark(commentPosition.from, commentPosition.to, commentMark));
......@@ -75,7 +75,7 @@ export default ({ comment, activeView, user }) => {
};
const resolveComment = () => {
// TODO Also find fragmented marks
// TODO pass correct comment pos for notes
const commentPosition = DocumentHelpers.findMarkPoistion(activeView, comment.pos, 'comment');
dispatch(state.tr.removeMark(commentPosition.from, commentPosition.to, commentMark));
};
......
......@@ -96,10 +96,11 @@ const findAllCommentsWithSameId = state => {
return allCommentsWithSameId;
};
// TODO Also find fragmented marks
const findMarkPosition = (activeView, initialPos, markType) => {
let $pos = activeView.state.tr.doc.resolve(initialPos);
let parent = $pos.parent;
let start = parent.childAfter($pos.parentOffset);
const $pos = activeView.state.tr.doc.resolve(initialPos);
const { parent } = $pos;
const start = parent.childAfter($pos.parentOffset);
if (!start.node) return null;
const actualMark = start.node.marks.find(mark => mark.type.name === markType);
let startIndex = $pos.index();
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment