Merge branch 'fix-sibling-figcaption' into 'master'

fix(services): check if image exists before getting siblings

See merge request !589

wax-prosemirror-services/src/ImageService/AltComponent.js

@@ -50,10 +50,12 @@ export default ({ setPosition, position }) => {
         `[data-fileid='${selection.node.attrs.fileid}']`,
       );
 
+    if (!image) return;
+
     const siblings = [...image.parentElement.children];
-    const figCaption = siblings.find(s => s.localName === 'figcaption');
+    const figCaption = siblings.find(s => s.tagName === 'FIGCAPTION');
 
-    if (!image || !figCaption) return;
+    if (!figCaption) return;
     const imagePosition = image.getBoundingClientRect();
     const figCaptionPosition = figCaption.getBoundingClientRect().height - 5;
     const left = imagePosition.left - WaxSurface.left;

wax-prosemirror-services/src/ImageService/LongDescComponent.js

@@ -53,10 +53,12 @@ export default ({ setPosition, position }) => {
         `[data-fileid='${selection.node.attrs.fileid}']`,
       );
 
+    if (!image) return;
+
     const siblings = [...image.parentElement.children];
-    const figCaption = siblings.find(s => s.localName === 'figcaption');
+    const figCaption = siblings.find(s => s.tagName === 'FIGCAPTION');
 
-    if (!image || !figCaption) return;
+    if (!figCaption) return;
     const imagePosition = image.getBoundingClientRect();
     const figCaptionPosition = figCaption.getBoundingClientRect().height + 10;
     const left = imagePosition.left - WaxSurface.left;