Merge branch 'test-happy-path' into 'master'

test: add e2e test for submission happy path

See merge request !32

app/components/dashboard/Dashboard.js

 import React from 'react'
-import { Link } from 'react-router-dom'
+import ButtonLink from '../ui/atoms/ButtonLink'
 
 const Dashboard = () => (
   <div>
     <h1>Dashboard Dummy Page</h1>
-    <Link to="/submit">Submit a manuscript</Link>
-    <div>
-      <Link to="/manuscript">View manuscript</Link>
-    </div>
+    <ButtonLink data-test-id="submit" primary to="/submit">
+      Submit a manuscript
+    </ButtonLink>
   </div>
 )
 

app/components/submission/AuthorDetails/AuthorDetails.js

@@ -68,7 +68,7 @@ class AuthorDetails extends React.Component {
 
         <Flex>
           <Box width={1}>
-            <Button primary type="submit">
+            <Button data-test-id="next" primary type="submit">
               Next
             </Button>
           </Box>

app/components/submission/FileUploads/FileUploads.js

@@ -26,7 +26,7 @@ const FileUploads = () => (
       </Box>
     </Flex>
 
-    <ButtonLink primary to="/submit/metadata">
+    <ButtonLink data-test-id="next" primary to="/submit/metadata">
       Next
     </ButtonLink>
     <ButtonLink to="/submit">Back</ButtonLink>

app/components/submission/ManuscriptMetadata/ManuscriptMetadataPage.js

@@ -9,7 +9,7 @@ export default () => (
 
     <H1>Help us get your work seen by the right people</H1>
 
-    <ButtonLink primary to="/submit/suggestions">
+    <ButtonLink data-test-id="next" primary to="/submit/suggestions">
       Next
     </ButtonLink>
     <ButtonLink to="/submit/upload">Back</ButtonLink>

app/components/submission/ReviewerSuggestions/ReviewerSuggestions.js

@@ -35,12 +35,7 @@ const MoreButton = ({
 
 const MAX_EXCLUDED_EDITORS = 2
 
-const ReviewerSuggestions = ({
-  handleSubmit,
-  values,
-  setValues,
-  setFieldValue,
-}) => (
+const ReviewerSuggestions = ({ handleSubmit, values, setFieldValue }) => (
   <form noValidate onSubmit={handleSubmit}>
     <ProgressBar currentStep={3} />
 
@@ -132,8 +127,8 @@ const ReviewerSuggestions = ({
 
     <Declaration />
 
-    <Button primary type="submit">
-      Next
+    <Button data-test-id="next" primary type="submit">
+      Submit
     </Button>
     <ButtonLink to="/submit/metadata">Back</ButtonLink>
   </form>

test/smoke.e2e.js

-import replay from 'replay'
-import { Selector } from 'testcafe'
-import { addUser } from '@pubsweet/db-manager'
-import { startServer, setup, teardown } from './helpers/setup'
-import { dashboard } from './pageObjects'
-
-replay.fixtures = `${__dirname}/http-mocks`
-
-const admin = {
-  username: 'tester',
-  email: 'tester@example.com',
-  password: 'password',
-  orcid: '0000-0001',
-  admin: true,
-}
-
-fixture('Smoke test')
-  .before(startServer)
-  .beforeEach(async () => {
-    await setup()
-    await addUser(admin)
-  })
-  .afterEach(teardown)
-
-test('Submission journey', async t => {
-  await t.navigateTo(dashboard.url)
-
-  // check that React root element exists
-  await t.expect(Selector('#root').exists).ok()
-})

test/submission.e2e.js

+import replay from 'replay'
+import { Selector, ClientFunction } from 'testcafe'
+import { addUser } from '@pubsweet/db-manager'
+import authentication from 'pubsweet-server/src/authentication'
+import { startServer, setup, teardown } from './helpers/setup'
+import { dashboard } from './pageObjects'
+
+replay.fixtures = `${__dirname}/http-mocks`
+
+const admin = {
+  username: 'tester',
+  email: 'tester@example.com',
+  password: 'password',
+  orcid: '0000-0001',
+  admin: true,
+}
+let token
+
+fixture('Submission')
+  .before(startServer)
+  .beforeEach(async () => {
+    await setup()
+    const user = await addUser(admin)
+    token = authentication.token.create(user)
+  })
+  .afterEach(teardown)
+
+const localStorageSet = ClientFunction((key, val) =>
+  localStorage.setItem(key, val),
+)
+
+test('Happy path', async t => {
+  // fake login by navigating to site and injecting token into local storage
+  await t.navigateTo(dashboard.url)
+  await localStorageSet('token', token)
+
+  await t.navigateTo(dashboard.url).click('[data-test-id=submit]')
+
+  // author details
+  await t
+    .typeText('[name=firstName]', 'Anne')
+    .typeText('[name=lastName]', 'Author')
+    .typeText('[name=email]', 'anne.author@life.ac.uk')
+    .typeText('[name=institute]', 'University of Life')
+    .click('[data-test-id=next')
+
+  // file uploads
+  await t.click('[data-test-id=next]')
+
+  // metadata
+  await t.click('[data-test-id=next]')
+
+  // reviewer suggestions
+  await t
+    .typeText('[name="suggestedSeniorEditors.0"]', 'Sen Yor')
+    .typeText('[name="suggestedSeniorEditors.1"]', 'Eddie Tar')
+    .typeText('[name="suggestedReviewingEditors.0"]', 'Rev. Ewing')
+    .typeText('[name="suggestedReviewingEditors.1"]', 'Ed Eater')
+    .typeText('[name="suggestedReviewers.0.name"]', 'Si Entist')
+    .typeText('[name="suggestedReviewers.0.email"]', 'si.entist@example.com')
+    .typeText('[name="suggestedReviewers.1.name"]', 'Reece Archer')
+    .typeText('[name="suggestedReviewers.1.email"]', 'reece@example.net')
+    .typeText('[name="suggestedReviewers.2.name"]', 'Dave')
+    .typeText('[name="suggestedReviewers.2.email"]', 'dave@example.org')
+    .click(Selector('[name=declaration]').parent())
+    .click('[data-test-id=next]')
+})