feat(login-orcid): implement login button that also handles the token
Expects the server to redirect back to a page that includes this component, passing the JWT in the URL hash.
Merge request reports
Activity
added 6 commits
-
891824e4...25abc506 - 5 commits from branch
master
- d7f2506f - feat(login-orcid): implement login button that also handles the token
-
891824e4...25abc506 - 5 commits from branch
added 1 commit
- 0a2a6609 - feat(login-orcid): implement login button that also handles the token
added 1 commit
- 4836c351 - feat(login-orcid): implement login button that also handles the token
added 1 commit
- f0a9b694 - feat(login-orcid): connect login button to LoginPage
added 1 commit
- 71ea04ed - feat(login-orcid): connect login button to LoginPage
added 17 commits
-
71ea04ed...b52670cb - 15 commits from branch
master
- 04b1fc75 - feat(login-orcid): implement login button that also handles the token
- e7d37174 - feat(login-orcid): connect login button to LoginPage
-
71ea04ed...b52670cb - 15 commits from branch
enabled an automatic merge when the pipeline for e7d37174 succeeds
added 4 commits
-
e7d37174...8eace60d - 2 commits from branch
master
- de4e9d02 - feat(login-orcid): implement login button that also handles the token
- b896a80a - feat(login-orcid): connect login button to LoginPage
-
e7d37174...8eace60d - 2 commits from branch
enabled an automatic merge when the pipeline for b896a80a succeeds
mentioned in commit c57868ce
This is very close to how I imagined a frontend ORCID component would look and function (understanding the token query param and what to do with it), even though it felt brittle (due to the number of moving parts that need to coordinate) in a way, there isn’t another way. And four
on the tests, it’s tricky stuff to abstract.I’ll open a discussion in PubSweet core about extending the Login component with generic OAuth functionality, using this as an example. Thanks for this!