Skip to content
Snippets Groups Projects

feat: update reviewer suggestions form

Merged feat: update reviewer suggestions form
reviewer-update into master
2 unresolved threads
Merged Tamlyn Rhodes requested to merge reviewer-update into master
2 unresolved threads
  • Add Textarea and CalloutBox elements

This is deliberately incomplete. According to @Nick only the initially displayed fields should be required and fields added by the user should be optional. This turns out to be hard to model with Yup. I spent a morning on it then decided to park it until we're sure this is the final behaviour. For now, every field is required.

The editor fields also need to be connected to the people picker component.

Edited by Tamlyn Rhodes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tamlyn Rhodes changed the description

    changed the description

  • Tamlyn Rhodes added 1 commit

    added 1 commit

    • cd23794b - feat: update reviewer suggestions form

    Compare with previous version

  • Tamlyn Rhodes added 1 commit

    added 1 commit

    • e558be27 - feat: update reviewer suggestions form

    Compare with previous version

  • Sam Galson
    Sam Galson @g-sam ·
    Maintainer

    Deployment is logging:

    error: FATAL ERROR, SHUTTING DOWN: Error: Configuration property "pubsweet-server.baseUrl" is not defined
    at Config.get (/home/xpub/node_modules/config/lib/config.js:202:11)
    at module.exports.app (/home/xpub/server/auth/orcid.js:15:29)
    at config.get.forEach.name (/home/xpub/node_modules/pubsweet-server/src/register-components.js:12:27)
    at Array.forEach (<anonymous>)
    at module.exports.app (/home/xpub/node_modules/pubsweet-server/src/register-components.js:7:39)
    at configureApp (/home/xpub/node_modules/pubsweet-server/src/index.js:52:3)
    at start (/home/xpub/node_modules/pubsweet-server/src/index.js:106:25)
    at Object.<anonymous> (/home/xpub/app.js:4:1)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3
  • Sam Galson
    Sam Galson @g-sam started a thread on the diff
app/components/submission/ReviewerSuggestions/ReviewerSuggestions.js
26 <PlainButton
27 onClick={() =>
28 setFieldValue(fieldName, values[fieldName].concat(empty), false)
29 }
30 type="button"
31 >
32 {type} {values[fieldName].length ? more : 'a'} {roleName}
33 </PlainButton>
34 )
35
36 const MAX_EXCLUDED_EDITORS = 2
37
38 const ReviewerSuggestions = ({
39 handleSubmit,
40 values,
41 setValues,
  • Sam Galson
  • Sam Galson
    Sam Galson @g-sam started a thread on the diff
    • app/components/ui/atoms/Textarea.js 0 → 100644
    1 import React from 'react'
    2 import styled from 'styled-components'
    3 import { th } from '@pubsweet/ui'
    4
    5 const Root = styled.div`
  • Sam Galson merged

    merged

  • Sam Galson mentioned in commit a4110939

    mentioned in commit a4110939

  • Tamlyn Rhodes
    Tamlyn Rhodes @tamlyn ·
    Author Maintainer

    Did you work out what was causing the deployment to fail?

  • Tamlyn Rhodes
    Tamlyn Rhodes @tamlyn ·
    Author Maintainer

    Ah yes, I remember now. production deployments are always expected to specify their baseUrl explicitly as there's no way for the app to determine it automatically.

    • Please register or sign in to reply