fix(mts-package): remove recommendations that have not been submitted

packages/component-fixture-manager/src/fixtures/fragments.js

@@ -118,6 +118,27 @@ const fragments = {
         createdOn: chance.timestamp(),
         updatedOn: chance.timestamp(),
       },
+      {
+        recommendation: 'reject',
+        recommendationType: 'review',
+        comments: [
+          {
+            content: 'This is not submitted yet',
+            public: true,
+            files: [
+              {
+                id: chance.guid(),
+                name: 'file.pdf',
+                size: chance.natural(),
+              },
+            ],
+          },
+        ],
+        id: chance.guid(),
+        userId: reviewer.id,
+        createdOn: chance.timestamp(),
+        updatedOn: chance.timestamp(),
+      },
     ],
     authors: [
       {

packages/component-helper-service/src/services/Fragment.js

@@ -159,6 +159,13 @@ class Fragment {
 
     const revAndEditorData = await Promise.all(
       recommendations.map(async rec => {
+        if (
+          rec.recommendationType === configRecommendations.type.review &&
+          !rec.submittedOn
+        ) {
+          return null
+        }
+
         const user = await UserModel.find(rec.userId)
         let assignmentDate, isReviewer
 
@@ -201,7 +208,7 @@ class Fragment {
       }),
     )
 
-    return revAndEditorData
+    return revAndEditorData.filter(Boolean)
   }
 }
 

packages/component-helper-service/src/tests/fragment.test.js

 process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'
 process.env.SUPPRESS_NO_CONFIG_WARNING = true
 
+const Chance = require('chance')
+const config = require('config')
 const { cloneDeep } = require('lodash')
 const fixturesService = require('pubsweet-component-fixture-service')
-const Chance = require('chance')
 
 const chance = new Chance()
 const { fixtures, Model } = fixturesService
 const { Fragment } = require('../Helper')
 
+const { recommendations: configRecommendations } = config
+
 const acceptedReviewerId = chance.guid()
 const submittedReviewerId1 = chance.guid()
 const submittedReviewerId2 = chance.guid()
@@ -240,7 +243,7 @@ describe('Fragment helper', () => {
     })
   })
   describe('getReviewersAndEditorsData', () => {
-    it('should return an array of users (reviewers, editors) that have a connection with the fragment', async () => {
+    it('should return an array of users (reviewers, editors) that have submitted a review', async () => {
       const { collection } = testFixtures.collections
       const { fragment } = testFixtures.fragments
       const fragmentHelper = new Fragment({ fragment })
@@ -251,7 +254,14 @@ describe('Fragment helper', () => {
       })
 
       expect(fragmentUsers.length).toBeGreaterThan(0)
-      expect(fragmentUsers).toHaveLength(fragment.recommendations.length)
+      const submittedRecommendations = fragment.recommendations.filter(
+        rec =>
+          rec.recommendationType === configRecommendations.type.editor ||
+          (rec.recommendationType === configRecommendations.type.review &&
+            rec.submittedOn),
+      )
+
+      expect(fragmentUsers).toHaveLength(submittedRecommendations.length)
     })
     it('should return an error when the collection does not have a handling editor', async () => {
       const { collection } = testFixtures.collections