fix(Only authors can see Reviewer Reports): Only authors can see Reviewer Reports

packages/component-faraday-selectors/src/index.js

@@ -80,7 +80,7 @@ export const authorCanViewReportsDetails = (
   collection = {},
   fragmentId,
 ) => {
-  const isAuthor = currentUserIsAuthor(state)
+  const isAuthor = currentUserIsAuthor(state, fragmentId)
   return (
     authorCanViewReportsDetailsStatuses.includes(
       get(collection, 'status', 'draft'),
@@ -153,7 +153,7 @@ export const canAuthorViewEditorialComments = (
   collection = {},
   fragmentId,
 ) => {
-  const isAuthor = currentUserIsAuthor(state)
+  const isAuthor = currentUserIsAuthor(state, fragmentId)
   return (
     isAuthor &&
     !cannotAuthorViewEditorialCommentsStatuses.includes(
@@ -251,10 +251,10 @@ export const canMakeRevision = (state, collection = {}, fragment = {}) => {
   )
 }
 
-export const currentUserIsAuthor = state => {
-  const authors = state.collections[0].owners.map(e => e.id)
-  const user = state.currentUser.user.id
-  return authors.includes(user)
+export const currentUserIsAuthor = (state, fragmentId) => {
+  const { id: userId } = selectCurrentUser(state)
+  const authors = get(state, `fragments.${fragmentId}.authors`, [])
+  return !!authors.find(a => a.id === userId)
 }
 
 export const getUserPermissions = ({ teams = [] }) =>
@@ -364,13 +364,17 @@ export const getInvitationsWithReviewersForFragment = (state, fragmentId) =>
 
 export const canMakeHERecommendation = (state, { collection, statuses }) => {
   const validHE = isHEToManuscript(state, get(collection, 'id', ''))
+  if (!validHE) return false
+
   const statusImportance = get(
     statuses,
     `${get(collection, 'status', 'draft')}.importance`,
     1,
   )
 
-  return statusImportance > 1 && statusImportance < 9 && validHE
+  if (!(statusImportance > 1 && statusImportance < 10)) return false
+
+  return true
 }
 
 export const getFragmentAuthorResponse = (state, fragmentId) =>
@@ -384,6 +388,7 @@ export const getFragmentReviewerRecommendations = (state, fragmentId) =>
   getFragmentRecommendations(state, fragmentId).filter(
     r => r.recommendationType === 'review',
   )
+
 const getFragmentEditorialComments = (state, fragmentId) =>
   getFragmentRecommendations(state, fragmentId).filter(
     r => r.recommendationType === 'editorRecommendation',