Upgrade pubsweet-client & React to version 16.2.0
I've opened this to track the work which also spans over to Wax (wax/wax!74 (merged)), and probably other things.
Edited by Tamlyn Rhodes
Merge request reports
Activity
Filter activity
Yeah, but there are still issues that I haven't figured out yet. Wax (post prop-types upgrade) specifically errors with:
substance.cjs.js:25038 Uncaught Error: 'el' is required. at Function.Component.mount (substance.cjs.js:25038) at Wax.mountEditor (Wax.js:158) at Wax.mountEditor (createPrototypeProxy.js:44) at Wax.componentDidMount (Wax.js:175) at Wax.proxiedComponentDidMount (createPrototypeProxy.js:66) at commitLifeCycles (react-dom.development.js:8770) at commitAllLifeCycles (react-dom.development.js:9946) at HTMLUnknownElement.callCallback (react-dom.development.js:542) at Object.invokeGuardedCallbackDev (react-dom.development.js:581) at invokeGuardedCallback (react-dom.development.js:438)
Haven't looked into it yet.
Edited by Jureadded 25 commits
-
9e3b8291...47b8888e - 24 commits from branch
master
- f82650ba - Merge remote-tracking branch 'origin/master' into react_upgrade
-
9e3b8291...47b8888e - 24 commits from branch
added 1 commit
- acd92a2f - Merge remote-tracking branch 'origin/master' into react_upgrade
Thanks @tamlyn, this looks good! Happy to see the new Wax version resolves React 16 issues. LGTM
mentioned in commit bb40334e
mentioned in commit pubsweet/pubsweet@dee29bd5
Please register or sign in to reply