Skip to content
Snippets Groups Projects

fix(reviewer panel): force curator to assess only submitted articles

Merged nickstiffler requested to merge curator-version-bug into master
All threads resolved!

@yannis This is what I came up with to force the curator to only access submitted versions. I still need to allow them to leave a review for the last submitted version, even if a decision has been made. Let me know this looks ok.

Edited by nickstiffler

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nickstiffler added 1 commit

    added 1 commit

    • 494114d4 - refactor(reviewer panel): clarify props

    Compare with previous version

  • nickstiffler added 19 commits

    added 19 commits

    • 494114d4...b116dbf6 - 15 commits from branch master
    • ea817d3b - fix(reviewer panel): force curator to assess only submitted articles
    • 4189afc2 - refactor(reviewer panel): clarify props
    • 585a42eb - refactor(reviewer panel): rebase
    • 1261f40e - Merge branch 'curator-version-bug' of...

    Compare with previous version

    Toggle commit list
  • Yannis Barlas
  • Yannis Barlas
  • @nickstiffler you never responded to my comments above.

  • nickstiffler added 12 commits

    added 12 commits

    • 1261f40e...077fad4f - 8 commits from branch master
    • 0a139b56 - fix(reviewer panel): force curator to assess only submitted articles
    • 7db01e65 - refactor(reviewer panel): clarify props
    • 8ad6cec0 - refactor(reviewer panel): rebase
    • 1e57b53a - Merge branch 'curator-version-bug' of...

    Compare with previous version

    Toggle commit list
  • nickstiffler added 1 commit

    added 1 commit

    Compare with previous version

  • Yannis Barlas added 1 commit

    added 1 commit

    • e754f8a6 - fix(reviewer panel): fix canStillReview logic for reviewer panel

    Compare with previous version

  • Yannis Barlas added 7 commits

    added 7 commits

    • cae33366 - 1 commit from branch master
    • 60a13443 - fix(reviewer panel): force curator to assess only submitted articles
    • 9a0c4494 - refactor(reviewer panel): clarify props
    • 993d1006 - refactor(reviewer panel): rebase
    • 4ff9247e - refactor(reviewer panel): clarify props
    • c55c3e3a - fix(*): logic
    • b241d910 - fix(reviewer panel): fix canStillReview logic for reviewer panel

    Compare with previous version

    Toggle commit list
  • Yannis Barlas resolved all threads

    resolved all threads

  • merged

  • @nickstiffler I changed this before merging as the reviewer panel was broken.

  • Please register or sign in to reply