fix: cr feedback

packages/component-faraday-selectors/src/index.js

@@ -183,15 +183,23 @@ const parseInvitedHE = (handlingEditor, state, collectionId) =>
       ? 'Invited'
       : handlingEditor.name,
   }
+
 const hideCustomIdStatuses = ['draft', 'technicalChecks']
-export const newestFirstParseDashboard = (state, items) =>
-  chain(items)
+
+export const parseCollectionDetails = (state, collection) => ({
+  ...collection,
+  customId:
+    !hideCustomIdStatuses.includes(get(collection, 'status', 'draft')) &&
+    collection.customId,
+  handlingEditor: parseInvitedHE(
+    collection.handlingEditor,
+    state,
+    collection.id,
+  ),
+})
+
+export const newestFirstParseDashboard = (state = {}) =>
+  chain(state.collections)
     .orderBy(['created'], ['desc'])
-    .map(item => ({
-      ...item,
-      customId:
-        !hideCustomIdStatuses.includes(get(item, 'status', 'draft')) &&
-        item.customId,
-      handlingEditor: parseInvitedHE(item.handlingEditor, state, item.id),
-    }))
+    .map(item => parseCollectionDetails(state, item))
     .value()

packages/component-faraday-ui/src/ManuscriptCard.js

@@ -26,7 +26,7 @@ const ManuscriptCard = ({
   onCardClick,
   fragment = {},
   manuscriptType = {},
-  collection: { visibleStatus = 'Draft', handlingEditor, customId },
+  collection: { visibleStatus = 'Draft', handlingEditor, customId, id: collId },
 }) => {
   const {
     authors = [],
@@ -82,7 +82,7 @@ const ManuscriptCard = ({
             <Item justify="flex-end" onClick={e => e.stopPropagation()}>
               <OpenModal
                 confirmText="Delete"
-                modalKey={`delete-${customId}`}
+                modalKey={`delete-${collId}`}
                 onConfirm={onDelete}
                 title="Are you sure you want to delete this submission?"
               >

packages/component-faraday-ui/src/manuscriptDetails/ManuscriptHeader.js

@@ -40,7 +40,7 @@ const ManuscriptHeader = ({
         </Row>
       )}
       <Row alignItems="center" justify="flex-start" mb={1}>
-        <Text customId mr={1}>{`ID ${customId}`}</Text>
+        {customId && <Text customId mr={1}>{`ID ${customId}`}</Text>}
         {submitted && (
           <DateParser durationThreshold={0} timestamp={submitted}>
             {timestamp => <Text mr={3}>Submitted on {timestamp}</Text>}

packages/component-manuscript/src/components/ManuscriptPage.js

@@ -37,6 +37,7 @@ import {
   pendingHEInvitation,
   currentUserIsReviewer,
   canMakeRecommendation,
+  parseCollectionDetails,
   canOverrideTechnicalChecks,
 } from 'pubsweet-component-faraday-selectors'
 import { RemoteOpener } from 'pubsweet-component-faraday-ui'
@@ -72,7 +73,10 @@ export default compose(
       handlingEditors: selectHandlingEditors(state),
       hasManuscriptFailure: hasManuscriptFailure(state),
       fragment: selectFragment(state, match.params.version),
-      collection: selectCollection(state, match.params.project),
+      collection: parseCollectionDetails(
+        state,
+        selectCollection(state, match.params.project),
+      ),
       pendingHEInvitation: pendingHEInvitation(state, match.params.project),
       editorialRecommendations: selectEditorialRecommendations(
         state,

packages/components-faraday/src/components/Dashboard/DashboardPage.js

@@ -21,7 +21,7 @@ export default compose(
     state => {
       const { collections, conversion } = state
       const currentUser = selectCurrentUser(state)
-      const dashboard = newestFirstParseDashboard(state, collections)
+      const dashboard = newestFirstParseDashboard(state)
 
       const userPermissions = getUserPermissions(state)
       return {