Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Commits
8e643d43
Commit
8e643d43
authored
6 years ago
by
Iosif Boanca
Browse files
Options
Downloads
Patches
Plain Diff
fix(HE should see decision box):
parent
28b3149a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
3 merge requests
!160
Update staging with master features
,
!150
Develop
,
!139
Hin 1054
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
packages/component-faraday-selectors/src/index.js
+20
-1
20 additions, 1 deletion
packages/component-faraday-selectors/src/index.js
packages/component-manuscript/src/components/ManuscriptLayout.js
+1
-2
1 addition, 2 deletions
...s/component-manuscript/src/components/ManuscriptLayout.js
with
21 additions
and
3 deletions
packages/component-faraday-selectors/src/index.js
+
20
−
1
View file @
8e643d43
...
@@ -361,13 +361,32 @@ export const getInvitationsWithReviewersForFragment = (state, fragmentId) =>
...
@@ -361,13 +361,32 @@ export const getInvitationsWithReviewersForFragment = (state, fragmentId) =>
export
const
canMakeHERecommendation
=
(
state
,
{
collection
,
statuses
})
=>
{
export
const
canMakeHERecommendation
=
(
state
,
{
collection
,
statuses
})
=>
{
const
validHE
=
isHEToManuscript
(
state
,
get
(
collection
,
'
id
'
,
''
))
const
validHE
=
isHEToManuscript
(
state
,
get
(
collection
,
'
id
'
,
''
))
if
(
!
validHE
)
return
false
const
statusImportance
=
get
(
const
statusImportance
=
get
(
statuses
,
statuses
,
`
${
get
(
collection
,
'
status
'
,
'
draft
'
)}
.importance`
,
`
${
get
(
collection
,
'
status
'
,
'
draft
'
)}
.importance`
,
1
,
1
,
)
)
return
statusImportance
>
1
&&
statusImportance
<
9
&&
validHE
if
(
!
(
statusImportance
>
1
&&
statusImportance
<
9
))
return
false
if
(
collection
.
fragments
.
length
!==
1
)
{
const
previousFragmentId
=
collection
.
fragments
[
collection
.
fragments
.
length
-
2
]
const
previousRecommendationType
=
chain
(
state
)
.
get
(
`fragments.
${
previousFragmentId
}
.recommendations`
,
[])
.
find
(
recommendation
=>
recommendation
.
recommendationType
===
'
editorRecommendation
'
,
)
.
get
(
'
recommendation
'
,
''
)
.
value
()
if
(
previousRecommendationType
===
'
minor
'
)
{
return
true
}
}
}
}
export
const
getFragmentAuthorResponse
=
(
state
,
fragmentId
)
=>
export
const
getFragmentAuthorResponse
=
(
state
,
fragmentId
)
=>
...
...
This diff is collapsed.
Click to expand it.
packages/component-manuscript/src/components/ManuscriptLayout.js
+
1
−
2
View file @
8e643d43
...
@@ -220,8 +220,7 @@ const ManuscriptLayout = ({
...
@@ -220,8 +220,7 @@ const ManuscriptLayout = ({
)}
)}
{
isLatestVersion
&&
{
isLatestVersion
&&
get
(
currentUser
,
'
permissions.canMakeHERecommendation
'
,
false
)
&&
get
(
currentUser
,
'
permissions.canMakeHERecommendation
'
,
false
)
&&
(
reviewerRecommendations
.
length
>
0
&&
(
<
HERecommendation
<
HERecommendation
formValues
=
{
get
(
formValues
,
'
editorialRecommendation
'
,
{})}
formValues
=
{
get
(
formValues
,
'
editorialRecommendation
'
,
{})}
hasReviewerReports
=
{
reviewerRecommendations
.
length
>
0
}
hasReviewerReports
=
{
reviewerRecommendations
.
length
>
0
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment