Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Commits
9bce0cc9
Commit
9bce0cc9
authored
6 years ago
by
Anca Ursachi
Browse files
Options
Downloads
Patches
Plain Diff
fix(editorialReportCard): changes after code review
parent
573a8422
No related branches found
No related tags found
1 merge request
!111
Hin 1059
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
packages/component-faraday-ui/src/EditorialReportCard.js
+16
-6
16 additions, 6 deletions
packages/component-faraday-ui/src/EditorialReportCard.js
with
16 additions
and
6 deletions
packages/component-faraday-ui/src/EditorialReportCard.js
+
16
−
6
View file @
9bce0cc9
...
@@ -17,6 +17,7 @@ const EditorialReportCard = ({
...
@@ -17,6 +17,7 @@ const EditorialReportCard = ({
recommendation
,
recommendation
,
editorName
,
editorName
,
editorRole
,
editorRole
,
handlingEditorName
,
collection
,
collection
,
report
:
{
createdOn
,
reviewer
},
report
:
{
createdOn
,
reviewer
},
})
=>
(
})
=>
(
...
@@ -35,7 +36,7 @@ const EditorialReportCard = ({
...
@@ -35,7 +36,7 @@ const EditorialReportCard = ({
{
reviewer
&&
(
{
reviewer
&&
(
<
Fragment
>
<
Fragment
>
<
Text
mr
=
{
1
/
2
}
>
<
Text
mr
=
{
1
/
2
}
>
{
e
ditorName
!==
'
Assigned
'
?
editorName
:
''
}
{
handlingE
ditorName
!==
'
Assigned
'
?
editorName
:
''
}
<
/Text
>
<
/Text
>
<
Tag
mr
=
{
2
}
>
{
editorRole
}
<
/Tag
>
<
Tag
mr
=
{
2
}
>
{
editorRole
}
<
/Tag
>
<
/Fragment
>
<
/Fragment
>
...
@@ -68,18 +69,20 @@ const EditorialReportCard = ({
...
@@ -68,18 +69,20 @@ const EditorialReportCard = ({
export
default
compose
(
export
default
compose
(
withHandlers
({
withHandlers
({
get
Reviewe
rRole
:
({
report
})
=>
()
=>
{
get
Edito
rRole
:
({
report
})
=>
()
=>
{
if
(
get
(
report
,
'
reviewer.handlingEditor
'
))
{
if
(
get
(
report
,
'
reviewer.handlingEditor
'
))
{
return
'
HE
'
return
'
HE
'
}
}
return
get
(
report
,
'
reviewer.editorInChief
'
)
?
'
EiC
'
:
''
return
get
(
report
,
'
reviewer.editorInChief
'
)
?
'
EiC
'
:
''
},
},
get
Reviewe
rName
:
({
report
})
=>
()
=>
get
Edito
rName
:
({
report
})
=>
()
=>
`
${
get
(
report
,
'
reviewer.firstName
'
,
''
)}
${
get
(
`
${
get
(
report
,
'
reviewer.firstName
'
,
''
)}
${
get
(
report
,
report
,
'
reviewer.lastName
'
,
'
reviewer.lastName
'
,
''
,
''
,
)}
`
,
)}
`
,
getHandlingEditorName
:
({
collection
})
=>
()
=>
`
${
get
(
collection
,
'
handlingEditor.name
'
,
''
)}
`
,
getRecommendationLabel
:
({
getRecommendationLabel
:
({
report
,
report
,
journal
:
{
recommendations
=
[]
},
journal
:
{
recommendations
=
[]
},
...
@@ -91,12 +94,19 @@ export default compose(
...
@@ -91,12 +94,19 @@ export default compose(
),
),
}),
}),
withProps
(
withProps
(
({
report
,
getReviewerRole
,
getReviewerName
,
getRecommendationLabel
})
=>
({
({
report
,
getEditorRole
,
getEditorName
,
getHandlingEditorName
,
getRecommendationLabel
,
})
=>
({
recommendation
:
getRecommendationLabel
(),
recommendation
:
getRecommendationLabel
(),
publicReport
:
getReportComments
({
report
,
isPublic
:
true
}),
publicReport
:
getReportComments
({
report
,
isPublic
:
true
}),
privateReport
:
getReportComments
({
report
,
isPublic
:
false
}),
privateReport
:
getReportComments
({
report
,
isPublic
:
false
}),
editorName
:
getReviewerName
(),
handlingEditorName
:
getHandlingEditorName
(),
editorRole
:
getReviewerRole
(),
editorName
:
getEditorName
(),
editorRole
:
getEditorRole
(),
}),
}),
),
),
)(
EditorialReportCard
)
)(
EditorialReportCard
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment