Merge branch 'HIN-1118' into 'develop'

fix(fragmentsRecommendations): reviewers cannot write a review on an older version

See merge request !147

packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js

@@ -78,6 +78,15 @@ module.exports = models => async (req, res) => {
       .json({ error: 'Cannot make a recommendation on an older version.' })
   }
 
+  if (
+    recommendationType === recommendations.type.review &&
+    last(collection.fragments) !== fragmentId
+  ) {
+    return res
+      .status(400)
+      .json({ error: 'Cannot write a review on an older version.' })
+  }
+
   if (
     recommendation === recommendations.publish &&
     recommendationType === recommendations.type.editor &&

packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js

@@ -384,6 +384,29 @@ describe('Post fragments recommendations route handler', () => {
       'Cannot make a recommendation on an older version.',
     )
   })
+  it('should return an error when a reviewer writes a review on an older version of a manuscript', async () => {
+    const { reviewer } = testFixtures.users
+    const { twoVersionsCollection } = testFixtures.collections
+    const { fragment } = testFixtures.fragments
+    body.recommendationType = 'review'
+
+    const res = await requests.sendRequest({
+      body,
+      userId: reviewer.id,
+      models,
+      route,
+      path,
+      params: {
+        collectionId: twoVersionsCollection.id,
+        fragmentId: fragment.id,
+      },
+    })
+
+    expect(res.statusCode).toBe(400)
+    const data = JSON.parse(res._getData())
+
+    expect(data.error).toEqual('Cannot write a review on an older version.')
+  })
 
   it('should return an error when an EiC makes a decision on an older version of a manuscript', async () => {
     const { editorInChief } = testFixtures.users