Merge branch 'refactor-component-invite' of...

Merge branch 'refactor-component-invite' of gitlab.coko.foundation:xpub/xpub-faraday into refactor-component-invite

packages/component-invite/src/routes/collectionsInvitations/delete.js

@@ -32,7 +32,9 @@ module.exports = models => async (req, res) => {
     collection.invitations = collection.invitations.filter(
       inv => inv.id !== invitation.id,
     )
-
+    if (invitation.role === 'handlingEditor') {
+      delete collection.handlingEditor
+    }
     await collection.save()
     await teamHelper.removeTeamMember(team.id, invitation.userId, models.Team)
     const user = await models.User.find(invitation.userId)

packages/component-user-manager/src/routes/collectionsUsers/patch.js

@@ -34,9 +34,10 @@ module.exports = models => async (req, res) => {
         error: 'Collection and user do not match',
       })
     }
-    matchingAuthor.firstName = firstName
-    matchingAuthor.lastName = lastName
-    matchingAuthor.affiliation = affiliation
+    user.firstName = firstName
+    user.lastName = lastName
+    user.affiliation = affiliation
+    await user.save()
     matchingAuthor.isSubmitting = isSubmitting
     matchingAuthor.isCorresponding = isCorresponding
     collection = await collection.save()

packages/component-user-manager/src/tests/collectionsUsers/patch.test.js

@@ -42,7 +42,8 @@ describe('Patch collections users route handler', () => {
     )
     expect(matchingAuthor.isSubmitting).toBe(body.isSubmitting)
     expect(matchingAuthor.isCorresponding).toBe(body.isCorresponding)
-    expect(matchingAuthor.firstName).toBe(body.firstName)
+    expect(submittingAuthor.firstName).toBe(body.firstName)
+    expect(submittingAuthor.lastName).toBe(body.lastName)
   })
   it('should return an error when the params are missing', async () => {
     delete body.isSubmitting