Skip to content
Snippets Groups Projects
Commit b3413b32 authored by Bogdan Cochior's avatar Bogdan Cochior
Browse files

feat(review): add conditional validation

parent 0ae0ac02
No related branches found
No related tags found
1 merge request!8Sprint #10
import React, { Fragment } from 'react'
import { isEmpty } from 'lodash'
import { connect } from 'react-redux'
import { required } from 'xpub-validators'
import { withJournal } from 'xpub-journal'
......@@ -115,7 +116,7 @@ const ReviewerReportForm = ({
/>
)}
name="public"
validate={[]}
validate={isEmpty(formValues.files) ? [required] : []}
/>
</FullWidth>
</Row>
......@@ -232,14 +233,10 @@ export default compose(
changeField: ({ changeForm }) => (field, value) => {
changeForm('reviewerReport', field, value)
},
addFile: ({
formValues: { files = [] },
uploadFile,
changeForm,
version,
}) => file => {
addFile: ({ formValues = {}, uploadFile, changeForm, version }) => file => {
uploadFile(file, 'review', version.id)
.then(file => {
const files = formValues.files || []
const newFiles = [...files, file]
setTimeout(() => {
......
......@@ -140,7 +140,7 @@ const onChange = (
const newValues = parseReviewRequest(values)
const prevValues = parseReviewRequest(previousValues)
if (!isEqual(newValues, prevValues) && !isEmpty(prevValues)) {
if (!isEqual(newValues, prevValues)) {
dispatch(autosaveRequest())
if (newValues.id) {
updateRecommendation(project.id, version.id, newValues)
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment