Merge branch 'develop' of gitlab.coko.foundation:xpub/xpub-faraday into develop

packages/component-helper-service/src/services/Email.js

@@ -465,7 +465,8 @@ class Email {
       parsedFragment: { id, title },
       authors: { submittingAuthor: { firstName = '', lastName = '' } },
     } = this
-    const user = get(collection, 'handlingEditor', {})
+    const handlingEditor = get(collection, 'handlingEditor', {})
+    const user = await UserModel.find(handlingEditor.id)
     if (!get(user, 'notifications.email.user')) return
 
     const userHelper = new User({ UserModel })
@@ -481,7 +482,7 @@ class Email {
         collection,
         eicName: `${eic.firstName} ${eic.lastName}`,
         fragment: { id, authorName: `${firstName} ${lastName}`, title },
-        handlingEditorName: user.name || '',
+        handlingEditorName: handlingEditor.name || '',
       },
     })
   }

packages/xpub-faraday/README.md

-## xPub-faraday  
+## xPub-faraday
 
-An MVP implementation of the first design sessions which allows a user to go through the process of creating a submission, assigning editors and reviewers, submitting reviews and submitting a decision.  
+A post-MVP implementation of the first design sessions which allows a user to go through the process of creating a submission, assigning editors and reviewers, submitting reviews and submitting a decision.
 
 ## Faraday Project Roadmap
 

packages/xpub-faraday/config/validations.js

@@ -132,7 +132,7 @@ module.exports = {
     invitationToken: Joi.string().allow(''),
     confirmationToken: Joi.string().allow(''),
     agreeTC: Joi.boolean(),
-    isActive: Joi.boolean().default(true),
+    isActive: Joi.boolean(),
     notifications: Joi.object({
       email: Joi.object({
         system: Joi.boolean().default(true),