fix(heMakeRecomandation): editorial recomandation visible before inviting reviewer

packages/component-faraday-ui/src/Tabs.js

@@ -4,12 +4,9 @@ const Tabs = ({ items, selectedTab, changeTab, children }) =>
   children({ selectedTab, changeTab })
 
 export default compose(
-  withStateHandlers(
-    { selectedTab: 0 },
-    {
-      changeTab: () => selectedTab => ({
-        selectedTab,
-      }),
-    },
-  ),
+  withStateHandlers(({ selectedTab = 0 }) => ({ selectedTab }), {
+    changeTab: () => selectedTab => ({
+      selectedTab,
+    }),
+  }),
 )(Tabs)

packages/component-faraday-ui/src/contextualBoxes/ReviewerDetails.js

@@ -21,7 +21,7 @@ import {
 
 const ReviewerDetails = ({
   journal,
-  reports,
+  reports = [],
   fragment,
   invitations,
   previewFile,
@@ -47,7 +47,7 @@ const ReviewerDetails = ({
       toggle={toggle}
       {...rest}
     >
-      <Tabs>
+      <Tabs selectedTab={reports.length ? 1 : 0}>
         {({ selectedTab, changeTab }) => (
           <Fragment>
             <TabsHeader>

packages/component-manuscript/src/components/ManuscriptLayout.js

@@ -181,15 +181,17 @@ const ManuscriptLayout = ({
           />
         )}
 
-        {get(currentUser, 'permissions.canMakeHERecommendation', false) && (
-          <HERecommendation
-            formValues={get(formValues, 'editorialRecommendation', {})}
-            hasReviewerReports={reviewerRecommendations.length > 0}
-            highlight={reviewerRecommendations.length > 0}
-            modalKey="heRecommendation"
-            onRecommendationSubmit={onEditorialRecommendation}
-          />
-        )}
+        {get(currentUser, 'permissions.canMakeHERecommendation', false) &&
+          (!invitationsWithReviewers.length ||
+            reviewerRecommendations.length > 0) && (
+            <HERecommendation
+              formValues={get(formValues, 'editorialRecommendation', {})}
+              hasReviewerReports={reviewerRecommendations.length > 0}
+              highlight={reviewerRecommendations.length > 0}
+              modalKey="heRecommendation"
+              onRecommendationSubmit={onEditorialRecommendation}
+            />
+          )}
 
         {get(currentUser, 'permissions.canMakeDecision', false) && (
           <ManuscriptEicDecision