feat(component-invite): add authsome to he teams

packages/component-invite/src/controllers/assignCollectionRole.js

@@ -67,7 +67,7 @@ module.exports = async (
   try {
     let user = await models.User.findByEmail(email)
 
-    let team = teamHelper.getTeamByGroupAndCollection(
+    let team = await teamHelper.getTeamByGroupAndCollection(
       collectionId,
       role,
       models.Team,
@@ -79,11 +79,13 @@ module.exports = async (
         collectionId,
         role,
       )
+      user = await models.User.findByEmail(email)
+    } else {
+      user.teams = user.teams || []
+      user.teams.push(team.id)
+      user = await user.save()
     }
 
-    // getting the updated user from the DB - creating a team also updates the user
-    user = await models.User.findByEmail(email)
-
     if (user.invitations === undefined) {
       user = await inviteHelper.setupInvitation(
         user,

packages/component-invite/src/helpers/Team.js

@@ -74,7 +74,7 @@ const setupEiCTeams = async (models, user) => {
 
 const setupManuscriptTeam = async (models, user, collectionId, role) => {
   const teams = await models.Team.all()
-  user.teams = []
+  user.teams = user.teams || []
   const filteredTeams = teams.filter(
     team =>
       team.group === role &&
@@ -89,12 +89,16 @@ const setupManuscriptTeam = async (models, user, collectionId, role) => {
     try {
       team = await team.updateProperties(team)
       team = await team.save()
+      user.teams.push(team.id)
+      await user.save()
       return team
     } catch (e) {
       logger.error(e)
     }
   } else {
     const team = await createNewTeam(collectionId, role, user.id, models.Team)
+    user.teams.push(team.id)
+    await user.save()
     return team
   }
 }

packages/xpub-faraday/config/authsome.js

@@ -3,30 +3,34 @@ const pickBy = require('lodash/pickBy')
 const omit = require('lodash/omit')
 
 async function teamPermissions(user, operation, object, context) {
-  const collection = get(object, 'collection')
-
-  if (collection) {
-    // Go through a user's teams, if they belong to a team that's based around
-    // this particular collection, check what membership in that team allows
-    // and return accordingly
-
-    /* eslint-disable */
-    for (const teamId of user.teams) {
+  const heTeamsProm = user.teams
+    .map(async teamId => {
       const team = await context.models.Team.find(teamId)
-
-      if (
-        team.teamType.permissions === 'handlingEditor' &&
-        team.object.id === collection.id &&
-        operation === 'GET'
-      ) {
-        console.log('team', team)
-        return true
+      if (team.teamType.permissions === 'handlingEditor') {
+        return team
       }
+      return null
+    })
+    .filter(Boolean)
+
+  const heTeams = await Promise.all(heTeamsProm)
+  const heCollections = heTeams.map(team => team.object.id)
+
+  if (heCollections.length > 0) {
+    return {
+      filter: collections => {
+        if (collections.length > 0) {
+          const correctColl = collections.filter(coll =>
+            heCollections.includes(coll.id),
+          )
+          return correctColl
+        }
+        return collections
+      },
     }
-    /* eslint-enable */
   }
 
-  return false
+  return {}
 }
 
 function unauthenticatedUser(operation, object) {