feat(authsome): enhance authsome to hide editorial comments until decision

packages/xpub-faraday/config/authsome-helpers.js

@@ -126,12 +126,13 @@ const hasFragmentInDraft = async ({ object, Fragment }) => {
   return isInDraft(fragment)
 }
 
-const filterAuthorRecommendationData = recommendation => {
-  const { comments } = recommendation
-  return {
-    ...recommendation,
-    comments: comments ? comments.filter(c => c.public) : [],
-  }
+const filterAuthorRecommendationData = (recommendations, status) => {
+  const canViewComments = authorAllowedStatuses.includes(status)
+  return recommendations.map(r => ({
+    ...r,
+    comments:
+      r.comments && canViewComments ? r.comments.filter(c => c.public) : [],
+  }))
 }
 
 const stripeCollectionByRole = (coll = {}, role = '') => {
@@ -151,14 +152,19 @@ const stripeCollectionByRole = (coll = {}, role = '') => {
   return coll
 }
 
-const stripeFragmentByRole = (fragment = {}, role = '', user = {}) => {
+const stripeFragmentByRole = (
+  fragment = {},
+  role = '',
+  status = '',
+  user = {},
+) => {
   const { recommendations, files, authors } = fragment
   switch (role) {
     case 'author':
       return {
         ...fragment,
         recommendations: recommendations
-          ? recommendations.map(filterAuthorRecommendationData)
+          ? filterAuthorRecommendationData(recommendations, status)
           : [],
       }
     case 'reviewer':

packages/xpub-faraday/config/authsome-mode.js

@@ -132,9 +132,12 @@ async function applyAuthenticatedUserPolicy(user, operation, object, context) {
 
       if (!permission) return false
 
+      const collectionId = get(object, 'fragment.collectionId')
+      const { status } = await context.models.Collection.find(collectionId)
+
       return {
         filter: fragment =>
-          helpers.stripeFragmentByRole(fragment, permission.role, user),
+          helpers.stripeFragmentByRole(fragment, permission.role, user, status),
       }
     }
 

packages/xpub-faraday/tests/authsome-helpers.test.js

@@ -112,6 +112,30 @@ describe('Authsome Helpers', () => {
     ]
     const result = ah.stripeFragmentByRole(fragment, 'author')
     const privateComments = get(result, 'recommendations[0].comments')
+    expect(privateComments).toHaveLength(0)
+  })
+  it('stripeFragment - author should see comments only if recommendation has been made', () => {
+    const { fragment } = testFixtures.fragments
+    fragment.recommendations = [
+      {
+        comments: [
+          {
+            content: 'private',
+            public: false,
+          },
+          {
+            content: 'public',
+            public: true,
+          },
+        ],
+      },
+    ]
+    const result = ah.stripeFragmentByRole(
+      fragment,
+      'author',
+      'revisionRequested',
+    )
+    const privateComments = get(result, 'recommendations[0].comments')
     expect(privateComments).toHaveLength(1)
   })
 })

[Alexandru Munteanu]

Default status should de 'draft'. That handles the case when fragment is still not submitted yet.

[Alexandru Munteanu]

In my opinion, one useful thing for functions with more than two parameters is instead to define only one object parameter. Sebi talked about it at a Show&Tell session and he already applies this on the backend.

More can be found here.

[Alexandru Munteanu]

If the current fragment is still in draft mode there won't be a status property present. Should have 'draft' assigned by default.