Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Commits
fd51a54d
Commit
fd51a54d
authored
6 years ago
by
Tania Fecheta
Browse files
Options
Downloads
Patches
Plain Diff
feat(authorCanSeeEditorialComments): hide editor name in styleguide
parent
9057963c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
2 merge requests
!110
Sprint 21 Features
,
!93
Hin 1013
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
packages/component-faraday-ui/src/EditorialReportCard.js
+2
-1
2 additions, 1 deletion
packages/component-faraday-ui/src/EditorialReportCard.js
packages/component-faraday-ui/src/EditorialReportCard.md
+7
-3
7 additions, 3 deletions
packages/component-faraday-ui/src/EditorialReportCard.md
with
9 additions
and
4 deletions
packages/component-faraday-ui/src/EditorialReportCard.js
+
2
−
1
View file @
fd51a54d
...
@@ -15,6 +15,7 @@ const EditorialReportCard = ({
...
@@ -15,6 +15,7 @@ const EditorialReportCard = ({
recommendation
,
recommendation
,
reviewerName
,
reviewerName
,
reviewerRole
,
reviewerRole
,
hideEditorName
,
report
:
{
createdOn
,
reviewer
},
report
:
{
createdOn
,
reviewer
},
})
=>
(
})
=>
(
<
Root
>
<
Root
>
...
@@ -27,7 +28,7 @@ const EditorialReportCard = ({
...
@@ -27,7 +28,7 @@ const EditorialReportCard = ({
<
Item
justify
=
"
flex-end
"
>
<
Item
justify
=
"
flex-end
"
>
{
reviewer
&&
(
{
reviewer
&&
(
<
Fragment
>
<
Fragment
>
<
Text
mr
=
{
1
/
2
}
>
{
reviewerName
}
<
/Text
>
<
Text
mr
=
{
1
/
2
}
>
{
hideEditorName
?
''
:
reviewerName
}
<
/Text
>
<
Tag
mr
=
{
2
}
>
{
reviewerRole
}
<
/Tag
>
<
Tag
mr
=
{
2
}
>
{
reviewerRole
}
<
/Tag
>
<
/Fragment
>
<
/Fragment
>
)}
)}
...
...
This diff is collapsed.
Click to expand it.
packages/component-faraday-ui/src/EditorialReportCard.md
+
7
−
3
View file @
fd51a54d
...
@@ -47,7 +47,8 @@ const journal = {
...
@@ -47,7 +47,8 @@ const journal = {
},
},
],
],
}
}
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
/>
const
hideEditorName
=
true
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
hideEditorName
=
{
hideEditorName
}
/>
```
```
Card with message for the editorial team
Card with message for the editorial team
...
@@ -97,7 +98,8 @@ const journal = {
...
@@ -97,7 +98,8 @@ const journal = {
},
},
],
],
}
}
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
/>
const
hideEditorName
=
false
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
hideEditorName
=
{
hideEditorName
}
/>
```
```
Card with message for the editorial team and for the author
Card with message for the editorial team and for the author
...
@@ -131,6 +133,7 @@ const report = {
...
@@ -131,6 +133,7 @@ const report = {
editorInChief
:
false
,
editorInChief
:
false
,
handlingEditor
:
true
,
handlingEditor
:
true
,
},
},
}
}
const
journal
=
{
const
journal
=
{
recommendations
:
[
recommendations
:
[
...
@@ -152,5 +155,6 @@ const journal = {
...
@@ -152,5 +155,6 @@ const journal = {
},
},
],
],
}
}
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
/>
const
hideEditorName
=
false
;
<
EditorialReportCard
report
=
{
report
}
journal
=
{
journal
}
hideEditorName
=
{
hideEditorName
}
/>
```
```
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment