Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Merge requests
!115
Hin 1038
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Hin 1038
hin-1038
into
develop
Overview
1
Commits
15
Pipelines
0
Changes
16
Merged
Andrei Cioromila
requested to merge
hin-1038
into
develop
6 years ago
Overview
1
Commits
15
Pipelines
0
Changes
2
Expand
1
0
Merge request reports
Viewing commit
8d580f8b
Prev
Next
Show latest version
2 files
+
7
−
11
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
8d580f8b
fix(recommendationsEmails): EQA emails logic
· 8d580f8b
Sebastian Mihalache
authored
6 years ago
packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
+
6
−
10
Options
@@ -145,16 +145,12 @@ module.exports = models => async (req, res) => {
const
hasPeerReview
=
!
isEmpty
(
collection
.
handlingEditor
)
if
(
isEditorInChief
)
{
if
(
recommendation
===
'
publish
'
&&
collection
.
technicalChecks
.
token
&&
[
'
accepted
'
,
'
inQA
'
].
includes
(
collection
.
status
)
)
{
if
(
collection
.
status
===
'
inQA
'
)
{
notification
.
notifyEAWhenEiCRequestsEQAApproval
()
}
else
{
notification
.
notifyEAWhenEiCMakesFinalDecision
()
}
if
(
recommendation
===
'
publish
'
&&
collection
.
status
===
'
inQA
'
)
{
notification
.
notifyEAWhenEiCRequestsEQAApproval
()
}
if
(
recommendation
===
'
publish
'
&&
collection
.
status
===
'
accepted
'
)
{
notification
.
notifyEAWhenEiCMakesFinalDecision
()
}
if
(
hasPeerReview
&&
(
recommendation
!==
'
publish
'
||
hasEQA
))
{