Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Commits
0bdef7e5
Commit
0bdef7e5
authored
6 years ago
by
Sebastian Mihalache
Browse files
Options
Downloads
Patches
Plain Diff
refactor(collection-helper): remove unused functions
parent
224a6db2
No related branches found
Branches containing commit
No related tags found
Tags containing commit
3 merge requests
!196
S25 - EiC submit revision
,
!189
S25
,
!177
Hin 230 eic request revision
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
packages/component-helper-service/src/services/Collection.js
+0
-34
0 additions, 34 deletions
packages/component-helper-service/src/services/Collection.js
with
0 additions
and
34 deletions
packages/component-helper-service/src/services/Collection.js
+
0
−
34
View file @
0bdef7e5
...
...
@@ -48,25 +48,6 @@ class Collection {
return
this
.
updateStatus
({
newStatus
})
}
async
updateFinalStatusByRecommendation
({
recommendation
})
{
let
newStatus
switch
(
recommendation
)
{
case
'
reject
'
:
newStatus
=
'
rejected
'
break
case
'
publish
'
:
newStatus
=
'
accepted
'
break
case
'
return-to-handling-editor
'
:
newStatus
=
'
reviewCompleted
'
break
default
:
break
}
await
this
.
updateStatus
({
newStatus
})
}
async
updateStatus
({
newStatus
})
{
this
.
collection
.
status
=
newStatus
await
this
.
collection
.
save
()
...
...
@@ -104,21 +85,6 @@ class Collection {
await
this
.
updateStatus
({
newStatus
:
'
heAssigned
'
})
}
async
updateStatusOnRecommendation
({
isEditorInChief
,
recommendation
})
{
if
(
isEditorInChief
)
{
if
(
recommendation
===
'
return-to-handling-editor
'
)
{
return
this
.
updateStatus
({
newStatus
:
'
reviewCompleted
'
})
}
return
this
.
updateFinalStatusByRecommendation
({
recommendation
,
})
}
return
this
.
updateStatusByRecommendation
({
recommendation
,
isHandlingEditor
:
true
,
})
}
getHELastName
()
{
const
[
firstName
,
lastName
]
=
this
.
collection
.
handlingEditor
.
name
.
split
(
'
'
)
return
lastName
||
firstName
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment