test(isAdmin): added unit tests for isAdmin function

packages/component-helper-service/src/services/User.js

@@ -64,7 +64,7 @@ class User {
     return eics
   }
 
-  async userIsAdmin(user) {
+  async isAdmin(user) {
     const { UserModel } = this
     const users = await UserModel.all()
     const admin = users.filter(user => user.admin)

packages/component-helper-service/src/tests/collection.test.js

@@ -5,7 +5,7 @@ const { cloneDeep } = require('lodash')
 const fixturesService = require('pubsweet-component-fixture-service')
 
 const { fixtures, Model } = fixturesService
-const { Collection, Fragment } = require('../Helper')
+const { Collection, Fragment, User } = require('../Helper')
 
 describe('Collection helper', () => {
   let testFixtures = {}
@@ -231,4 +231,26 @@ describe('Collection helper', () => {
       expect(canHEMakeRecommendation).toBe(false)
     })
   })
+
+  describe('isAdmin', () => {
+    it('should return true if user is admin', async () => {
+      const { admin } = testFixtures.users
+      const adminId = admin.id
+      const UserModel = models.User
+      const userHelper = new User({ UserModel })
+      const isAdmin = await userHelper.isAdmin(adminId)
+
+      expect(isAdmin).toBe(true)
+    })
+
+    it('should return false if user is not admin', async () => {
+      const { reviewer } = testFixtures.users
+      const reviewerId = reviewer.id
+      const UserModel = models.User
+      const userHelper = new User({ UserModel })
+      const isAdmin = await userHelper.isAdmin(reviewerId)
+
+      expect(isAdmin).toBe(false)
+    })
+  })
 })

packages/component-manuscript-manager/src/routes/collections/delete.js

@@ -62,7 +62,7 @@ module.exports = models => async (req, res) => {
       fragment.files.manuscripts,
       fragment.files.coverLetter,
       fragment.files.supplementary,
-      fragmentId,
+      { id: fragmentId },
     )
 
     fileKeys = fileKeys.map(file => file.id)

packages/component-manuscript-manager/src/routes/fragments/notifications/notifications.js

@@ -57,9 +57,7 @@ module.exports = {
     const fragmentHelper = new Fragment({ fragment })
     const collectionOwners = get(collection, 'owners')
     const userHelper = new User({ UserModel })
-    const adminOwner = collectionOwners.find(owner =>
-      userHelper.userIsAdmin(owner),
-    )
+    const adminOwner = collectionOwners.find(owner => userHelper.isAdmin(owner))
     const handlingEditor = get(collection, 'handlingEditor')
     const parsedFragment = await fragmentHelper.getFragmentData({
       handlingEditor,