fix(fragmentRecommendations): use findLast instead of two filters and cover the undefined case

packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js

 const uuid = require('uuid')
-const { pick, get, set, has, isEmpty, last } = require('lodash')
+const { pick, get, set, has, isEmpty, last, findLast } = require('lodash')
 const config = require('config')
 const { v4 } = require('uuid')
 const logger = require('@pubsweet/logger')
@@ -41,11 +41,14 @@ module.exports = models => async (req, res) => {
     })
   }
 
-  const currentUserRecommendation = get(fragment, 'recommendations', []).filter(
-    r => r.userId === req.user,
-  )
+  const currentUserRecommendations = get(
+    fragment,
+    'recommendations',
+    [],
+  ).filter(r => r.userId === req.user)
 
-  const returnToHERecommendations = get(fragment, 'recommendations', []).filter(
+  const returnToHERecommendation = findLast(
+    get(fragment, 'recommendations', []),
     r => r.recommendation === 'return-to-handling-editor',
   )
   const authsome = authsomeHelper.getAuthsome(models)
@@ -80,21 +83,22 @@ module.exports = models => async (req, res) => {
 
   if (
     last(collection.fragments) === fragmentId &&
-    !isEmpty(currentUserRecommendation)
+    !isEmpty(currentUserRecommendations)
   ) {
     if (recommendationType === recommendations.type.review) {
       return res
         .status(400)
         .json({ error: 'Cannot write another review on this version.' })
-    }
-    if (
+    } else if (
       recommendationType === recommendations.type.editor &&
-      last(returnToHERecommendations).createdOn <
-        last(currentUserRecommendation).createdOn
+      ((returnToHERecommendation &&
+        returnToHERecommendation.createdOn <=
+          last(currentUserRecommendations).createdOn) ||
+        !returnToHERecommendation)
     ) {
-      return res
-        .status(400)
-        .json({ error: 'Cannot make another recommendation on this version.' })
+      return res.status(400).json({
+        error: 'Cannot make another recommendation on this version.',
+      })
     }
   }