Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xpub-faraday
Manage
Activity
Members
Labels
Plan
Issues
2
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Releases
Container Registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
xpub
xpub-faraday
Commits
6cdaccf5
Commit
6cdaccf5
authored
6 years ago
by
Sebastian Mihalache
Browse files
Options
Downloads
Patches
Plain Diff
fix(collection-service): remove he id check from canHEMakeRecommendation
parent
13f106ac
No related branches found
No related tags found
3 merge requests
!176
Sprint 24
,
!171
Sprint 24
,
!165
Hin 845 revoke and assign he
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
packages/component-helper-service/src/services/Collection.js
+6
-4
6 additions, 4 deletions
packages/component-helper-service/src/services/Collection.js
with
6 additions
and
4 deletions
packages/component-helper-service/src/services/Collection.js
+
6
−
4
View file @
6cdaccf5
...
@@ -147,17 +147,19 @@ class Collection {
...
@@ -147,17 +147,19 @@ class Collection {
[],
[],
)
)
const
lastRecommendation
ByHE
=
findLast
(
const
last
Editor
Recommendation
=
findLast
(
previousVersionRecommendations
,
previousVersionRecommendations
,
recommendation
=>
recommendation
=>
recommendation
.
userId
===
this
.
collection
.
handlingEditor
.
id
&&
recommendation
.
recommendationType
===
'
editorRecommendation
'
,
recommendation
.
recommendationType
===
'
editorRecommendation
'
,
)
)
if
(
lastRecommendationByHE
.
recommendation
===
'
minor
'
)
{
if
(
lastEditorRecommendation
.
recommendation
===
'
minor
'
)
{
return
this
.
hasAtLeastOneReviewReport
(
fragments
)
return
this
.
hasAtLeastOneReviewReport
(
fragments
)
}
else
if
(
lastRecommendation
ByHE
.
recommendation
===
'
major
'
)
{
}
else
if
(
last
Editor
Recommendation
.
recommendation
===
'
major
'
)
{
return
fragmentHelper
.
hasReviewReport
()
return
fragmentHelper
.
hasReviewReport
()
}
}
return
false
}
}
async
getAllFragments
({
FragmentModel
})
{
async
getAllFragments
({
FragmentModel
})
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment