refactor(authsome-helpers): change function filterReviewersRecommendation into 2 smaller functions

packages/xpub-faraday/config/authsome-helpers.js

@@ -72,20 +72,20 @@ const filterAuthorRecommendations = (recommendations, status, isLast) => {
   return []
 }
 
-const filterReviewerRecommendations = (recommendations, user, isLast) => {
+const filterRecommendationsFromLastVersion = (recommendations, user) =>
+  recommendations
+    .filter(
+      r =>
+        r.userId === user.id || r.recommendationType === 'editorRecommendation',
+    )
+    .map(r => ({
+      ...r,
+      comments: r.comments.filter(c => c.public === true),
+    }))
+
+const filterRecommendationsFromOlderVersions = (recommendations, user) => {
   const ownRecommendation = recommendations.find(r => r.userId === user.id)
-  if (isLast) {
-    return recommendations
-      .filter(
-        r =>
-          r.userId === user.id ||
-          r.recommendationType === 'editorRecommendation',
-      )
-      .map(r => ({
-        ...r,
-        comments: r.comments.filter(c => c.public === true),
-      }))
-  } else if (ownRecommendation) {
+  if (ownRecommendation) {
     return recommendations
       .filter(
         r => r.submittedOn || r.recommendationType === 'editorRecommendation',
@@ -124,7 +124,8 @@ const stripeFragmentByRole = ({
   user = {},
   isLast = false,
 }) => {
-  const { recommendations, files, authors } = fragment
+  const { files, authors, recommendations } = fragment
+  let recommendationsFromFragment
   switch (role) {
     case 'author':
       return {
@@ -134,13 +135,22 @@ const stripeFragmentByRole = ({
           : [],
       }
     case 'reviewer':
+      if (isLast && recommendations) {
+        recommendationsFromFragment = filterRecommendationsFromLastVersion(
+          recommendations,
+          user,
+        )
+      } else if (recommendations) {
+        recommendationsFromFragment = filterRecommendationsFromOlderVersions(
+          recommendations,
+          user,
+        )
+      } else recommendationsFromFragment = []
       return {
         ...fragment,
         files: omit(files, ['coverLetter']),
         authors: authors.map(a => omit(a, ['email'])),
-        recommendations: recommendations
-          ? filterReviewerRecommendations(recommendations, user, isLast)
-          : [],
+        recommendations: recommendationsFromFragment,
       }
     case 'handlingEditor':
       return {