refactor(ManuscriptHeader): Create a new const that holds the value used in...

refactor(ManuscriptHeader): Create a new const that holds the value used in two places and move erro

packages/component-faraday-ui/src/helpers/utils.js

 import { get, chain, find } from 'lodash'
 
 export const handleError = fn => e => {
-  const errorForAuthorWhenHEWasRevoked =
-    'Your Handling Editor was changed. A new handling editor will be assigned to your manuscript soon. Sorry for the inconvenience.'
-  let error = get(
-    JSON.parse(e.response),
-    'error',
-    'Oops! Something went wrong!',
-  )
-  if (error === 'No revision has been found.') {
-    error = errorForAuthorWhenHEWasRevoked
-  }
-  fn(error)
+  fn(get(JSON.parse(e.response), 'error', 'Oops! Something went wrong!'))
 }
 
 export const getReportComments = ({ report, isPublic = false }) =>

packages/component-faraday-ui/src/manuscriptDetails/ManuscriptHeader.js

@@ -135,27 +135,22 @@ export default compose(
       if (pendingInvitation.userId === currentUserId) {
         return <Text ml={1}>Invited</Text>
       }
-      if (
-        (get(pendingInvitation, 'userId', false) ||
-          get(heInvitation, 'userId', false)) &&
-        (admin || editorInChief)
-      ) {
+      const invitedHeId =
+        get(pendingInvitation, 'userId', false) ||
+        get(heInvitation, 'userId', false)
+
+      if (invitedHeId && (admin || editorInChief)) {
         const person = chain(handlingEditors)
-          .filter(
-            he =>
-              he.id ===
-              (get(heInvitation, 'userId', false) ||
-                get(pendingInvitation, 'userId', false)),
-          )
+          .filter(he => he.id === invitedHeId)
           .map(he => ({ ...he, name: `${he.firstName} ${he.lastName}` }))
           .first()
           .value()
 
-        let invitedPerson = {}
+        let invitedHe = {}
         if (get(pendingInvitation, 'userId', false)) {
-          invitedPerson = pendingInvitation
+          invitedHe = pendingInvitation
         } else if (get(heInvitation, 'userId', false)) {
-          invitedPerson = heInvitation
+          invitedHe = heInvitation
         }
         return (
           <PersonInvitation
@@ -163,7 +158,7 @@ export default compose(
             isLatestVersion={isLatestVersion}
             ml={1}
             withName
-            {...invitedPerson}
+            {...invitedHe}
             onResend={resendInvitation}
             onRevoke={revokeInvitation}
             person={person}

packages/component-manuscript-manager/src/routes/fragments/patch.js

@@ -24,7 +24,8 @@ module.exports = models => async (req, res) => {
     fragment = await models.Fragment.find(fragmentId)
     if (!fragment.revision) {
       return res.status(400).json({
-        error: 'No revision has been found.',
+        error:
+          'Your Handling Editor was changed. A new handling editor will be assigned to your manuscript soon. Sorry for the inconvenience.',
       })
     }
 

packages/component-manuscript-manager/src/tests/fragments/patch.test.js

@@ -148,7 +148,9 @@ describe('Patch fragments route handler', () => {
 
     expect(res.statusCode).toBe(400)
     const data = JSON.parse(res._getData())
-    expect(data.error).toEqual('No revision has been found.')
+    expect(data.error).toEqual(
+      'Your Handling Editor was changed. A new handling editor will be assigned to your manuscript soon. Sorry for the inconvenience.',
+    )
   })
   it('should return an error when the user is inactive', async () => {
     const { inactiveUser } = testFixtures.users