Skip to content
Snippets Groups Projects
Commit 0c5fcaee authored by Sebastian Mihalache's avatar Sebastian Mihalache :hammer_pick:
Browse files

fix(recommendations): fix CR notes

parent 635e85aa
No related branches found
No related tags found
3 merge requests!196S25 - EiC submit revision,!189S25,!177Hin 230 eic request revision
......@@ -21,7 +21,7 @@ const requestRevisionAsHE = require('./strategies/heRequestRevision')
const requestRevisionAsEiC = require('./strategies/eicRequestRevision')
module.exports = models => async (req, res) => {
const { recommendation, comments, recommendationType } = req.body
const { recommendation, comments = [], recommendationType } = req.body
if (!services.checkForUndefinedParams(recommendationType, recommendation))
return res.status(400).json({ error: 'Recommendation type is required.' })
......@@ -74,11 +74,11 @@ module.exports = models => async (req, res) => {
const newRecommendation = {
userId,
id: v4(),
comments,
recommendation,
recommendationType,
createdOn: Date.now(),
updatedOn: Date.now(),
comments: comments || [],
}
const notification = new Notification({
......
......@@ -7,7 +7,7 @@ module.exports = {
newRecommendation,
}) => {
const fragments = await collectionHelper.collection.getFragments()
// console.log('FRAGs', fragments)
if (!collectionHelper.canHEMakeRecommendation(fragments, fragmentHelper)) {
throw new Error('Cannot publish without at least one reviewer report.')
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment